Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use p12 for signing certificate #300

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Conversation

ubamrein
Copy link
Contributor

Change the CryptoProvider to use a base64 encoded P12 and a corresponding password to load the signing certificate and signing private key. This unifies the EfgsGatewayConfig so that both key pairs use a p12 container to store private and public material.

During this the configuration properties of the EfgsGatewayConfig changed, so care has to be taken during update.

Also missing tests for the CryptoProvider were added.

@ubhaller ubhaller force-pushed the feature/crypto-provider-uses-p12 branch from 0f51a09 to 4e9c4ad Compare April 21, 2021 08:16
@martinalig martinalig force-pushed the feature/crypto-provider-uses-p12 branch from 6afacbd to 5ae34ea Compare April 21, 2021 11:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

58.5% 58.5% Coverage
0.0% 0.0% Duplication

@ubamrein ubamrein merged commit 2d58cd1 into develop Apr 21, 2021
@ubamrein ubamrein deleted the feature/crypto-provider-uses-p12 branch April 21, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants