Add Multi-Cardinality Support to DedupliFHIR Backend #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
IsaacMilarky
added
enhancement
IsaacMilarky
requested review from
natalialuzuriaga,
decause-gov and
patsier-cms
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| else: | ||
| blocking_rules.append(block_on(rule)) | ||
| def get_additional_comparison_rules(parsed_data_df): | ||
|
|
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0303: Trailing whitespace (trailing-whitespace)
Signed-off-by: Isaac Milarsky <[email protected]>
|
Looks like the installation for tests on 3.11 is failing, is that a fluke or does that need to be updated? |
Signed-off-by: Isaac Milarsky <[email protected]>
Sorry I was just merging in Dependabot updates. It's just a fluke and is fixed now |
patsier-cms
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Multi-Cardinality Support to DedupliFHIR Backend
Problem
Currently, the dedupliFHIR tool only supports a specific column structure when processing user-inputted data. Meaning, that the columns that the tool checks for and compares are predefined and static.
For example, if the user input a piece of data that included more than one street address or postal code it would be ignored by the tool.
This problem is detailed in this issue: #54
Solution
I have added functionality to support multi-cardinality if it is found in the input data. Both FHIR and CSV data now include support for multiple names, addresses, and postal codes.
Result
Tests have been adapted to use more than one address, the settings for the Splink backend are now computed after the data is parsed instead of before the data is parsed, etc.
Test Plan
Run
make test