Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied the improvements in tardy TP handling from v4 to v5. #386

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

bieryAtFnal
Copy link
Collaborator

@bieryAtFnal bieryAtFnal commented Oct 16, 2024

These changes are dependent on ones in appmodel. And, there is a change in daqsystemtest that depends on this one.

I have re-run the tests that are described in PR #358, and the majority of the integtest in the daqsystemtest repo continue to work with these changes.

@eflumerf
Copy link
Member

Does this resolve #384?

@bieryAtFnal
Copy link
Collaborator Author

It copies the improved handling of tardy TPs in the TPStreamWriter from v4 to v5. It does not affect the generation of tardy TPs in the readout subsystem.

@eflumerf
Copy link
Member

Last 5 data points in opmon from my test run:

"dfmodules.TPStreamWriterInfo": {
                    "bytes_output": {
                        "2024-10-16T16:09:03.362012723Z": "13674320",
                        "2024-10-16T16:09:13.371019370Z": "13674432",
                        "2024-10-16T16:09:23.380455738Z": "13674432",
                        "2024-10-16T16:09:33.389888657Z": "13674320",
                        "2024-10-16T16:09:43.398761181Z": "13674320"
                    },
                    "heartbeat_tpsets_received": {
                        "2024-10-16T16:08:53.353372625Z": "0",
                        "2024-10-16T16:09:03.362012723Z": "0",
                        "2024-10-16T16:09:13.371019370Z": "0",
                        "2024-10-16T16:09:23.380455738Z": "0",
                        "2024-10-16T16:09:33.389888657Z": "0",
                        "2024-10-16T16:09:43.398761181Z": "0"
                    },
                    "tardy_timeslice_max_seconds": {
                        "2024-10-16T16:09:03.362012723Z": "0",
                        "2024-10-16T16:09:13.371019370Z": "0",
                        "2024-10-16T16:09:23.380455738Z": "0",
                        "2024-10-16T16:09:33.389888657Z": "0",
                        "2024-10-16T16:09:43.398761181Z": "0"
                    },
                    "timeslices_written": {
                        "2024-10-16T16:09:03.362012723Z": "10",
                        "2024-10-16T16:09:13.371019370Z": "10",
                        "2024-10-16T16:09:23.380455738Z": "10",
                        "2024-10-16T16:09:33.389888657Z": "10",
                        "2024-10-16T16:09:43.398761181Z": "10"
                    },
                    "total_tps_received": {
                        "2024-10-16T16:09:03.362012723Z": "9063308",
                        "2024-10-16T16:09:13.371019370Z": "9307629",
                        "2024-10-16T16:09:23.380455738Z": "9552020",
                        "2024-10-16T16:09:33.389888657Z": "9796466",
                        "2024-10-16T16:09:43.398761181Z": "10040817"
                    },
                    "total_tps_written": {
                        "2024-10-16T16:09:03.362012723Z": "9032301",
                        "2024-10-16T16:09:13.371019370Z": "9276443",
                        "2024-10-16T16:09:23.380455738Z": "9520585",
                        "2024-10-16T16:09:33.389888657Z": "9764725",
                        "2024-10-16T16:09:43.398761181Z": "10008865"
                    },
                    "tps_received": {
                        "2024-10-16T16:09:03.362012723Z": "244379",
                        "2024-10-16T16:09:13.371019370Z": "244321",
                        "2024-10-16T16:09:23.380455738Z": "244391",
                        "2024-10-16T16:09:33.389888657Z": "244446",
                        "2024-10-16T16:09:43.398761181Z": "244351"
                    },
                    "tps_written": {
                        "2024-10-16T16:09:03.362012723Z": "244140",
                        "2024-10-16T16:09:13.371019370Z": "244142",
                        "2024-10-16T16:09:23.380455738Z": "244142",
                        "2024-10-16T16:09:33.389888657Z": "244140",
                        "2024-10-16T16:09:43.398761181Z": "244140"
                    },
                    "tpsets_with_tps_received": {
                        "2024-10-16T16:09:03.362012723Z": "5870",
                        "2024-10-16T16:09:13.371019370Z": "5871",
                        "2024-10-16T16:09:23.380455738Z": "5867",
                        "2024-10-16T16:09:33.389888657Z": "5872",
                        "2024-10-16T16:09:43.398761181Z": "5871"
                    }
                }

Copy link
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, unit tests run, regression tests behave normally. Observed opmon metrics from long run, posted as comment on PR

@bieryAtFnal bieryAtFnal merged commit e1d6f92 into develop Oct 16, 2024
1 of 2 checks passed
@bieryAtFnal bieryAtFnal deleted the kbiery/tpsw_v4_to_v5 branch October 16, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants