Adding OpMon publisher for drunc #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plasorak
approved these changes
Jan 23, 2025
| _context.publisher.publish( | ||
| session="test_runnumber_session", | ||
| application="test_runnumber_app", | ||
| message = TestInfo( |
There was a problem hiding this comment.
Could you define a protobuf schema in druncschema rather than using TestInfo?
| _context.publisher.publish( | ||
| session="test_runnumber_session", | ||
| application="test_runnumber_app", | ||
| message = TestInfo( |
| @@ -244,6 +247,7 @@ def can_execute_transition(self, source_state, transition) -> bool: | |||
|
|
|||
|
|
|||
| def prepare_transition(self, transition, transition_data, transition_args, ctx=None): | |||
| ctx.publisher = self.publisher | |||
There was a problem hiding this comment.
https://github.com/DUNE-DAQ/drunc/pull/339/files#diff-1c8bca3bf6f1ba6689f1ffe354b3be800f9bb7e9143ebc3bdbd45bf558f4897dR620 There is no need to do that here, you can directly do ctx.opmon_publisher.publish in the actions, since ctx = controller
|
|
||
| self.configuration = conf | ||
| self.publisher = publisher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.