Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update connection strings if they contained a wildcard. #56

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Only update connection strings if they contained a wildcard. #56

merged 2 commits into from
Jun 8, 2023

Conversation

eflumerf
Copy link
Member

@eflumerf eflumerf commented May 3, 2023

No description provided.

@eflumerf eflumerf requested a review from plasorak May 3, 2023 12:34
@eflumerf eflumerf self-assigned this May 3, 2023
This was referenced May 3, 2023
Merged
Closed
@eflumerf
Copy link
Member Author

eflumerf commented May 3, 2023

Resolves #50

@eflumerf
Copy link
Member Author

Pinging this set of PRs.

@plasorak
Copy link
Contributor

Could you explain a bit why this is needed?

@eflumerf
Copy link
Member Author

If the connection string contains a wildcard, it means that ZMQ will be instructed to bind to a dynamic port number or all interfaces (* == 0.0.0.0). This dynamic information must be resolved locally before being published to the ConnectivityService so that remote endpoints may connect to the correct IP and port.

@eflumerf
Always set config_client_interval, as it is used by the subscriber
83935b9 
update thread.

Make the Data structs in IOManager_test different.
plasorak
plasorak approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm don't think I'm able to review the changes in the unittest, changes in NetworkManager look good.

@plasorak plasorak merged commit d5a48a0 into develop Jun 8, 2023
@plasorak plasorak deleted the eflumerf/DontResolveConnect branch June 8, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasorak plasorak plasorak approved these changes

Assignees

@eflumerf eflumerf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eflumerf @plasorak