Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a variation on the ALICE pad position class for square pixels #16

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tomjunk
Copy link
Member

@tomjunk tomjunk commented Oct 1, 2024

On Patrick's request, I made a new version of the AliTPCROC class, called AliTPCROCSquare, with adjusted parameters for square pads, 6 mm on a side. There are still IROC, OROC (just one kind of pad in the OROC now), and CROC. Enclosed are plots of the pad locations, and an event with raw digits over threshold and reconstructed tracks. There are now 508906 pads per side. The geometry is still double-sided with a cathode in the middle. This is easy enough to switch in the future, though the cathode-crossing track stitcher module should be taken out of the reco for that.
squarepixelsrecoexample1
squarepixelsrawexample1
squarepixels

@tomjunk tomjunk requested a review from pjdunne October 1, 2024 22:44
@tomjunk
Copy link
Member Author

tomjunk commented Oct 1, 2024

It is a breaking change for anyone who has files with raw digits or hits in them. TPC Clusters and downstream data products are not affected.

@tomjunk
Copy link
Member Author

tomjunk commented Oct 2, 2024

To do: change the Pad Readout Functions (PRFs) to be all the CROC one, as that was designed for 6 mm x 6 mm square pads.

@tomjunk
Copy link
Member Author

tomjunk commented Oct 2, 2024

And look at Leo's additions to the TPC Clustering algorithm which are pad-row aware. With a more isotropic detector, the algorithms may stay, but parameters adjusted so they treat the directions in a row and perpendicular to a row equally.

One thing we might think about is not having a square grid of pixel pads but stagger them a bit so you don't get artificially straight segments which is the current problem when a track follows along a pad row. Such segments can be quite long even for gently curving tracks in the OOROC, which is why ALICE does a poor job of reconstructing those. I should check -- the geometry may be staggered anyway due to the fact that square pixels are arranged in a trapezoidal ROC.

@pjdunne pjdunne requested a review from naseemkhan99 October 2, 2024 13:07
Copy link

@naseemkhan99 naseemkhan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be an option in the config (if it isn't already)? So the old readout can still be utilised?

@tomjunk
Copy link
Member Author

tomjunk commented Oct 9, 2024

I can look into seeing if I can make the square pad class inherit from the ALICE one. That way the downstream use of it can be switched easily just by setting a pointer or reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants