Prevent crash when reloading LIGHT_GAIN #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if set_light_properties were called a second time on a detector with a different number of optical channels as on the first call, loading of LIGHT_GAIN could crash as the "default" for detprop.get would be np.full(OP_CHANNEL_EFFICIENCY.shape, LIGHT_GAIN), where LIGHT_GAIN is an array with all of the channels of the first call, so the broadcast into OP_CHANNEL_EFFICIENCY.shape fails.
krwood
reviewed
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if set_light_properties were called a second time on a detector with a different number of optical channels as on the first call, loading of LIGHT_GAIN could crash as the "default" for detprop.get would be np.full(OP_CHANNEL_EFFICIENCY.shape, LIGHT_GAIN), where LIGHT_GAIN is an array with all of the channels of the first call, so the broadcast into OP_CHANNEL_EFFICIENCY.shape fails.
This was causing larnd-display to fail when configured with more than one geometry, since set_light_properties was getting called for both detectors.