Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support eventID separator as a command-line option #109

Closed
wants to merge 3 commits into from
Closed

support eventID separator as a command-line option #109

wants to merge 3 commits into from

Conversation

drinkingkazu
Copy link
Contributor

a minor change so that a user doesn't have to locally install larnd-sim nor modify the system path install to use a string value "eventID" as a separator (the default kept as spillID)

@drinkingkazu
Copy link
Contributor Author

Added another piece of change that logs the time and memory usage over simulation steps for understanding the performance in laymans term w/o using nvprof outside.

@krwood
Copy link
Member

krwood commented Mar 8, 2023

#111 reads in EVENT_SEPARATOR and other formerly hard coded configurations through a configuration file instead of from the command line. I would like to merge that in and then revise this PR to get your memory logger in. How does that sound to you?

@krwood krwood self-assigned this Mar 17, 2023
@drinkingkazu
Copy link
Contributor Author

@krwood config file sounds good. yes please merge the mem logger! sorry i was traveling till April...

@drinkingkazu
Copy link
Contributor Author

Closing to open a new PR for memory logger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants