Feature t0 vertex #140
Merged
Feature t0 vertex #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krwood
approved these changes
Jun 10, 2023
There was a problem hiding this comment.
@YifanC and I tested this this new feature by running the simulation on an events with segments ("tracks" in larnd-sim) that saturate the the MAX_TRACKS_PER_PIXEL configuration variable. The situation is handled much more sensibly with this PR.
- Before: all of the fractional contributions sum up to 1 by construction
- After: a pixel that has been "saturated" in the simulation would be indicated by the fractional contributions not summing up to 1
This is a very similar solution to Issue #137 as Pull Request #138, but is also robust to the randomness from the noise simulation. Merging this PR should also close both #137 and #138.
Comment on lines
+453
to
+455
| #tot_backtracked = 0 | ||
| #for itrk in range(current_fractions.shape[2]): | ||
| # tot_backtracked += current_fractions[ip][iadc][itrk] |
There was a problem hiding this comment.
[nit-picky comment alert] Might as well remove the commented out, legacy code
…efault it's set to be off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.