Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add true event_id to backtracking information #183

Merged
merged 1 commit into from
Dec 26, 2023
Merged

add true event_id to backtracking information #183

merged 1 commit into from
Dec 26, 2023

Conversation

YifanC
Copy link
Collaborator

@YifanC YifanC commented Dec 26, 2023 •
edited
Loading

Adding true event id to the packet mc assn to aid downstream backtracking. The updates are tested and are fairly isolated.

@YifanC YifanC merged commit 2346070 into develop Dec 26, 2023
@YifanC YifanC linked an issue Dec 27, 2023 that may be closed by this pull request
add true event_id to the backtracking dataset #177
Closed
krwood
krwood reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@krwood krwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event_id information should be accessible through having the segment(/track)_id, but this does provide easier access. Something to keep in mind in case we want to trim down file size though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krwood krwood krwood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add true event_id to the backtracking dataset
2 participants
@YifanC @krwood