merge light wvfm mc assn in the output #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the name of the feature branch, it doesn't solve the cupy illegal memory issue associated with light.MAX_MC_TRUTH_IDS. I set the light mc association to be off in the configuration file. This truth association gives backtracking information per light readout channel per time tick in the readout window. If we do not know how to use this information downstream, I would think
light_dat
in the output would be enough to give a sense what segments contribute to the light signals, which it stores the segments yield how many photons to each light readout channel and their arrival times.For completeness, I updated the light mc association dataset in the output so it is consistent than what it would be before the module-to-module variation change.