Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pixel pitch for Module 2 #218

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

jaafar-chakrani
Copy link
Member

No description provided.

@krwood
Copy link
Member

krwood commented May 1, 2024

This is a band aid that solves the issues we were seeing with the module 2 offsets reported by @russellphysics https://indico.fnal.gov/event/64244/contributions/288617/attachments/176623/240114/minirun5_spatial_offset___2x2_simulation_calibration___8april2024.pdf

@jaafar-chakrani found the discrepancy with how ndlar_flow and larnd-sim calculate pixel position, which is sketched out here https://indico.fnal.gov/event/64542/contributions/290387/attachments/177430/241559/20240429_GeometryBugFix.pdf along with the validation of the agreement when adjusting the pixel pitch on the last page.

Eventually, we should change the larnd-sim pixel position calculation to be like what is done in ndlar_flow, using the center position for the tiles rather than assuming they are all adjacent.

@krwood krwood merged commit e9fdcc0 into DUNE:develop May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants