Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature light lut #247

Merged
merged 7 commits into from
Aug 31, 2024
Merged

Feature light lut #247

merged 7 commits into from
Aug 31, 2024

Conversation

YifanC
Copy link
Collaborator

@YifanC YifanC commented Aug 31, 2024

  • Use lut t0 profile to sample instead of using the average
  • Use measured SiPM model instead of the RLC model
Screenshot 2024-08-31 at 9 57 57 AM
  • Use pre-caclulated time profile instead of calculate it on the fly (This part should be static). You can see the differences of light_sample_inc (the direct outcome of this change). Note there's no randomness up to this step. I'm not sure this is hits the precision limit? Compare to the current way how we use LUT, it's not faster... Testing on 3 events, this PR takes ~145s, while using the current LUT takes 125s. I can factor this out in the PR if necessary.
Screenshot 2024-08-31 at 9 24 47 AM
  • Not add first photon arrival time if not threshold triggered
  • Only allow one trigger per event

@mjkramer mjkramer merged commit bd36cbf into develop Aug 31, 2024
@YifanC YifanC mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants