Light Sim Addition #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soleti
reviewed
Nov 9, 2021
larndsim/lightLUT.py
Outdated
| def GetVoxel(pos,lut_geometry): # Determines which voxel is being called based on the position of the edep. Voxels are indexed 0-2911 | ||
|
|
||
| (lut_min,lut_max,lut_ndiv) = lut_geometry | ||
| vox_xyz = np.floor(pos/(lut_max-lut_min)*lut_ndiv).astype(int)+lut_ndiv/2 |
There was a problem hiding this comment.
I don't quite understand here, you apply the floor function, then cast to integer and then add a float? What's a typical value for lut_ndiv?
There was a problem hiding this comment.
this function now gets the voxel from the global coordinate system with a single int call (see https://github.com/tairaeli/larnd-sim/blob/larnd-branch/larndsim/lightLUT.py#L33)
…ell as some of the comments on some of the lines of code that were not clearly explained
…the removal of some unnecessary code
…Not complete yet. Still need to be fully integrated into the rest of the lightLUT
…into larnd-branch
…n. Also removed the get_lut_geometry function and added the lut geometries to the module0.yaml file. Testing still required
…ulation. Fixed errors in coordinate translation
…based on tpc_borders
…into larnd-branch
…d random "out of bounds" edeps
…into larnd-branch
soleti
reviewed
Nov 29, 2021
…into larnd-branch
infophysics
pushed a commit
to infophysics/larnd-sim
that referenced
this pull request
Jul 14, 2023
Light Sim Addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a light simulation model relying on a light lookup table. Made some additions to a few of the other modules to account for these additions.