Prevent out of range indexing #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to have an invalid time index in the atomic add in `sum_pixel_signals`. This happens fairly frequently but there is no runtime error when the index is only slightly out of range. For an event with a track with a very late start tick (event 15 of `/dune/data2/users/awilkins/extrapolation/nd_cafs/edep/0m/00/FHC.1000000.edep.h5`) I get a cuda runtime error. `cuda-gdb` with memcheck switched on pointed to these atomic adds as the cause.
soleti
approved these changes
Jul 12, 2022
|
Thank you for catching this and taking the time of making the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have an invalid time index in the atomic add in
sum_pixel_signals. This happens fairly frequently but there is no runtime error when the index is only slightly out of range. For an event with a track with a very late start tick (event 15 of/dune/data2/users/awilkins/extrapolation/nd_cafs/edep/0m/00/FHC.1000000.edep.h5) I get a cuda runtime error.cuda-gdbwith memcheck switched on pointed to these atomic adds as the cause.