Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better support for Shrek 2 (PC) #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Master65
Copy link

With this change, provided I read the code correctly, should allow for making UnrealLoads be able to act as a more proper autosplitter and load remover for Shrek 2 (PC). Currently however, there's two issues I potentially see with it.

First off, loading a save splits at the moment... perhaps this is because the testing I did was without the changes here (I wouldn't know as I don't understand the library of code yet)? Second off, the autosplitter doesn't automatically split at the end of the run, which is when FGM dies (the first frame of the cutscene appearing after doing so). Obviously this is expected as there's no code in place to specifically split at that moment. I'm unaware if it's possible to attempt to autosplit with the game's CutLog or not, but if that could be possible to add, then I'd be interested in making that an option. If not, that wouldn't be a big deal.

The save-load causing a split to occur would be a deal breaker, but again, perhaps adding a list of maps fixes this? Would need confirmation.

@Dalet
Copy link
Owner

Dalet commented Jun 17, 2023

Hello,

Before anything, I must ask, why contribute to this repository when the current registered LiveSplit autosplitter is https://github.com/Master-64/Shrek2-LiveSplit?
As far as I'm concerned the UnrealLoads implementation is obsolete.
I always prefer when communities have full control over their autosplitter, since I'm not very active in this space anymore.

@Master-64
Copy link

At the moment, there have been a few requests by others that want to see whether or not UnrealLoads would perform better than the current autosplitter/load remover that's currently being used. I'm not planning on outright changing the autosplitter everyone uses with this push request, rather it's more of a test to see how UnrealLoads works with Shrek 2, so that the community can test it out more and see if it's actually better or not. I get that this repo is quite old, however I believe it would be beneficial for testing purposes, even if it doesn't work as intended.

@TheTedder
Copy link
Contributor

This should be okay to merge even if it isn't used since it's just adding some more game names and map names. Just my two cents.

@Dalet
Copy link
Owner

Dalet commented Jun 24, 2023

First off, loading a save splits at the moment...

If I remember correctly the saves have their own map name so they could be ignored or filtered with the map list.

I'm unaware if it's possible to attempt to autosplit with the game's CutLog or not

It could be added in Shrek2.cs and coexist with map load splitting, I don't see why not.

If for now you just want people to test it, you can build and distribute the .dll file yourself. It doesn't make sense to merge a work-in-progress version.

Later it would be preferable to add the functionality to your autosplitter. Feel free to use this repo's code as reference, or even directly copy/paste.
I've (re)joined the Shrekciety discord if you want to discuss this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants