milestone_2 completed

app/src/main/java/com/example/androidproject/ArticleAdapter.java

@@ -1,5 +1,7 @@
 package com.example.androidproject;
 
+
+import android.annotation.SuppressLint;
 import android.content.Context;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -10,8 +12,8 @@
 import androidx.annotation.Nullable;
 import java.util.ArrayList;
 
-public class ArticleAdapter extends ArrayAdapter<ArticleModel> {
-
+public class ArticleAdapter extends ArrayAdapter<ArticleModel>
+{
     private final ItemClick itemClick;
 
     public interface ItemClick {
@@ -27,7 +29,7 @@ public ArticleAdapter(@NonNull Context context, ArrayList<ArticleModel> data, It
     @Override
     public View getView(int position, @Nullable View convertView, @NonNull ViewGroup parent) {
         ArticleModel data = getItem(position);
-        View view = LayoutInflater.from(getContext()).inflate(R.layout.item_article, parent, false);
+        @SuppressLint("ViewHolder") View view = LayoutInflater.from(getContext()).inflate(R.layout.item_article, parent, false);
         view.findViewById(R.id.root).setOnClickListener(v -> itemClick.onClick(v, data));
         ((TextView) view.findViewById(R.id.web_title)).setText(data.getTitle());
         ((TextView) view.findViewById(R.id.web_url)).setText(data.getUrl());

app/src/main/java/com/example/androidproject/ArticleModel.java

@@ -3,6 +3,7 @@
 import android.os.Parcel;
 import android.os.Parcelable;
 
+
 public class ArticleModel implements Parcelable {
     private String id;
     private String title;
@@ -15,7 +16,6 @@ public ArticleModel(String id, String title, String url, String sectionName) {
         this.url = url;
         this.sectionName = sectionName;
     }
-
     public String getId() {
         return id;
     }

app/src/main/java/com/example/androidproject/FavoriteActivity.java

@@ -3,13 +3,19 @@
 import android.app.Activity;
 import android.content.Intent;
 import android.os.Bundle;
+import android.view.Menu;
+import android.view.MenuInflater;
+import android.view.MenuItem;
 import android.view.View;
 import android.widget.ListView;
+
+import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AppCompatActivity;
 import androidx.appcompat.widget.Toolbar;
 import java.util.ArrayList;
 
+
 public class FavoriteActivity extends AppCompatActivity implements ArticleAdapter.ItemClick {
 
     public static final String KEY_IS_DELETE = "KEY_IS_DELETE";
@@ -19,7 +25,8 @@ public class FavoriteActivity extends AppCompatActivity implements ArticleAdapte
     private ArticleAdapter arrayAdapter;
 
     @Override
-    protected void onCreate(@Nullable Bundle savedInstanceState) {
+    protected void onCreate(@Nullable Bundle savedInstanceState)
+    {
         super.onCreate(savedInstanceState);
 
         setContentView(R.layout.activity_favorite);
@@ -29,8 +36,11 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
 
         setSupportActionBar(toolbar);
 
-        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
-        getSupportActionBar().setDisplayShowHomeEnabled(true);
+        if (getSupportActionBar() != null)
+        {
+            getSupportActionBar().setDisplayHomeAsUpEnabled(true);
+            getSupportActionBar().setDisplayShowHomeEnabled(true);
+        }
 
         articleModels.addAll(GDatabase.getInstance(this).get());
         arrayAdapter = new ArticleAdapter(this, articleModels, this);
@@ -54,4 +64,21 @@ protected void onActivityResult(int requestCode, int resultCode, @Nullable Inten
             arrayAdapter.notifyDataSetChanged();
         }
     }
+
+    @Override
+    public boolean onCreateOptionsMenu(Menu menu) {
+        MenuInflater inflater = getMenuInflater();
+        inflater.inflate(R.menu.menu, menu);
+        return super.onCreateOptionsMenu(menu);
+    }
+
+    @Override
+    public boolean onOptionsItemSelected(@NonNull MenuItem item) {
+        if (item.getItemId() == R.id.menu_help) {
+            utils.showDialogHelp(this, getString(R.string.help_item_favorite));
+            return true;
+        }
+        return super.onOptionsItemSelected(item);
+    }
+
 }

app/src/main/java/com/example/androidproject/FavoriteContract.java

@@ -10,4 +10,6 @@ public class FavoriteContract
     public static final String COLUMN_TITLE = "title";
     public static final String COLUMN_URL = "url";
     public static final String COLUMN_SECTION_NAME = "section_name";
+
 }
+

app/src/main/java/com/example/androidproject/FavoriteDetailsActivity.java

@@ -48,23 +48,24 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
         btnOpenInBrowser.setOnClickListener(v -> utils.openBrowser(v, articleModel.getUrl()));
 
         FloatingActionButton fabSave = findViewById(R.id.fab_save);
+
         fabSave.setOnClickListener(v -> {
             AlertDialog.Builder builder = new AlertDialog.Builder(v.getContext());
-            builder.setTitle("Are you sure want to delete from favorites?");
+            builder.setTitle(R.string.dialog_title_delete_favorite);
             builder.setCancelable(true);
-            builder.setPositiveButton("Yes", (dialog, id) -> {
+            builder.setPositiveButton(R.string.yes, (dialog, id) -> {
                 if (GDatabase.getInstance(getBaseContext()).delete(articleModel.getId())) {
-                    Toast.makeText(v.getContext(), "Success Delete To Favorite", Toast.LENGTH_LONG).show();
+                    Toast.makeText(v.getContext(), v.getContext().getString(R.string.success_delete_favorite), Toast.LENGTH_LONG).show();
                     Intent intent = new Intent();
                     intent.putExtra(FavoriteActivity.KEY_IS_DELETE, true);
                     setResult(Activity.RESULT_OK, intent);
                     finish();
                 } else {
-                    Toast.makeText(v.getContext(), "Fail Delete To Favorite", Toast.LENGTH_LONG).show();
+                    Toast.makeText(v.getContext(), v.getContext().getString(R.string.fail_delete_favorite), Toast.LENGTH_LONG).show();
                 }
                 dialog.cancel();
             });
-            builder.setNegativeButton("No", (dialog, id) -> dialog.cancel());
+            builder.setNegativeButton(R.string.no,(dialog, id) -> dialog.cancel());
             AlertDialog dialog = builder.create();
             dialog.show();
         });

app/src/main/java/com/example/androidproject/GDatabase.java

@@ -22,14 +22,17 @@ public static GDatabase getInstance(Context context) {
         return guardianDatabase;
     }
 
+
     private static final String DATABASE_NAME = "guardian";
 
-    private GDatabase(Context context) {
+    private GDatabase(Context context)
+    {
         super(context, DATABASE_NAME, null, 1);
     }
 
     @Override
-    public void onCreate(SQLiteDatabase db) {
+    public void onCreate(SQLiteDatabase db)
+    {
         db.execSQL(FavoriteContract.QUERY_CREATE_TABLE);
     }
 

app/src/main/java/com/example/androidproject/GuardianApi.java

@@ -48,11 +48,12 @@ private static GuardianResponse jsonObjectToGuardianResponse(JSONObject jsonObje
         );
     }
 
+
     public static GuardianResponse search(@Nullable String query) throws Throwable {
         StringBuilder stringUrl = new StringBuilder(BASE_URL);
         stringUrl.append("/search?api-key=1fb36b70-1588-4259-b703-2570ea1fac6a");
         stringUrl.append("&page-size=50");
-        if (query !=null) stringUrl.append("&q=").append(query);
+        if (query !=null) stringUrl.append(query);
 
         URL url = new URL(stringUrl.toString());
 

app/src/main/java/com/example/androidproject/GuardianAsyncTask.java

@@ -5,8 +5,8 @@
 import android.os.Looper;
 import androidx.annotation.Nullable;
 
-public class GuardianAsyncTask extends AsyncTask<String, Void, GuardianResponse> {
-
+public class GuardianAsyncTask extends AsyncTask<String, Void, GuardianResponse>
+{
     public interface Callback {
         void onPreExecute();
 
@@ -17,6 +17,7 @@ public interface Callback {
 
     private final Callback callback;
 
+
     @SuppressWarnings("deprecation")
     public GuardianAsyncTask(Callback callback) {
         this.callback = callback;
@@ -28,6 +29,7 @@ protected void onPreExecute() {
         callback.onPreExecute();
     }
 
+
     @Override
     protected GuardianResponse doInBackground(String... strings) {
         String query = strings.length > 0 ? strings[0] : null;

app/src/main/java/com/example/androidproject/GuardianResponse.java

@@ -3,7 +3,8 @@
 import androidx.annotation.NonNull;
 import java.util.List;
 
-public class GuardianResponse {
+public class GuardianResponse
+{
     private String status;
     private String userTier;
     private int total;

app/src/main/java/com/example/androidproject/GuardianResult.java

@@ -29,6 +29,7 @@ public GuardianResult(String id, String type, String sectionId, String sectionNa
         this.pillarName = pillarName;
     }
 
+
     public String getId() {
         return id;
     }

app/src/main/java/com/example/androidproject/HttpError.java

@@ -9,3 +9,4 @@ public HttpError(@Nullable String message)
         super(message);
     }
 }
+