Properly support wildcard when not in a section of its own #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamonOehlman
commented
Apr 27, 2017
| @@ -35,9 +37,9 @@ | |||
|
|
|||
| function WildcardMatcher(text, separator) { | |||
| this.text = text = text || ''; | |||
| this.hasWild = ~text.indexOf('*'); | |||
| this.hasWild = text.indexOf('*') >= 0; | |||
There was a problem hiding this comment.
Use of ~ was just trying to be clever. Replaced with something sensible.
|
Good stuff! +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised and discussed in #8 whereby a string such as
*foowouldn't match stringfoo. This wasn't the goal of the library as it was only built to mimic the behaviour of the wildcard usage withineve. However, it is completely legitimate given the name of the package and the contexts that people would expect it to work in.NOTE: ES5 code style maintained for compatibility with older browsers, and well why rewrite for the sake of it.
@revelt @bradennapier A quick review would be appreciated. I think using
matcheris the correct path forward for most people and I that as an alternative on the README, but think getting this package right is probably worthwhile also.