Merge pull request #92 from DanCardin/dc/bad-error-message

fix: Incorrect error message when using an invalid base class type.

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.15.3
+
+- fix: Incorrect error message when using an invalid base class type.
+
 ## 0.15.2
 
 - fix: Process `action` inference, taking into account `Optional`/`| None`.

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "cappa"
-version = "0.15.2"
+version = "0.15.3"
 description = "Declarative CLI argument parser."
 
 repository = "https://github.com/dancardin/cappa"

src/cappa/class_inspect.py

@@ -50,8 +50,8 @@ def from_cls(cls, obj: type) -> ClassTypes:
         if hasattr(obj, "__attrs_attrs__"):
             return cls.attrs
 
-        raise ValueError(  # pragma: no cover
-            f"'{cls}' is not a currently supported base class. "
+        raise ValueError(
+            f"'{obj.__qualname__}' is not a currently supported kind of class. "
             "Must be one of: dataclass, pydantic, or attrs class."
         )
 

tests/test_class_inspect.py

@@ -0,0 +1,14 @@
+import pytest
+from cappa.class_inspect import ClassTypes
+
+
+def test_invalid_class_base():
+    class Random:
+        ...
+
+    with pytest.raises(ValueError) as e:
+        ClassTypes.from_cls(Random)
+    assert (
+        "'test_invalid_class_base.<locals>.Random' is not a currently supported kind of class."
+        in str(e.value)
+    )