fix: handle missing pydantic-core corner case #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change handles a corner case where
pydantic
is installed in the environment butpydantic-core
is missing. The current code assumes that if pydantic is importable, then pydantic is available, but the access ofpydantic.BaseModel
does a lazy import ofpydantic-core
which is not handled, crashing the application that is usingcappa
.To handle the issue,
BaseModel
is imported eagerly during the detection step, which will throw an error whenpydantic-core
is not available.I have observed this in the wild, where I am not using
pydantic
with cappa at all, nor it is one of my direct dependencies, but it is still being pulled transitively from other sources, crashing my application. This issue surfaced with https://github.com/DanCardin/cappa/releases/tag/v0.19.0.