Fix: update for pip and docker #86
Conversation
|
Huh - that's neat. It looks like there's something up with the Windows build. This was definitely something I saw at the top of the cmake file that I'm wondering if it was supposed to make it into main at this time? |
wyattearp
force-pushed
the
fix-update-pipx-docker
branch
from
525e1bf to
3a31a89
Compare
|
I've got a change that looks like this will make WSL function correctly with picotool. Seems I've also been hitting this issue as well raspberrypi/pico-sdk#1820 (comment) I'm going to tweak the container again and see if this resolves the build to make it operational on both. Moving back to draft. |
wyattearp
changed the title
|
Thank you for the updates and attention to the docker scripts. I'll away your final pull request. |
wyattearp
changed the title
|
This should address the previous limitations on the docker container, also fixing the fact that the Ref:
@DangerousPrototypes -- know any WSL users that can test out a windows .devcontainer in vscode? :-D |
now using the default cmake instead of the python one to align to the operting system's preferred directions. this shouldn't really be an issue as there's nothing extremely fancy going on in cmake also moving the docker compose to my personal repo for now, need to talk with the bp team if they're fine with me actually pushing a real org for them.
now using the default cmake instead of the python one to align to the operting system's preferred directions. this shouldn't really be an issue as there's nothing extremely fancy going on in cmake also moving the docker compose to my personal repo for now, need to talk with the bp team if they're fine with me actually pushing a real org for them.
with the inclusion of these changes, we address the python weirdness for cmake as well as we now correct the issue with picotool being unable to bootstrap. it comes at the cost that if we update picotool to a different version, we have to update the docker, but that appears to be a documented issue in their bugs so ... until that's better we're going to have to stick with that. also added the .devcontainers for vscode users. this should just "bring up" a build environment for the vscode system. tested only on linux, but looking for windows volunteers. do note that if it fails to build, it's likely that you have a permissions issue on your current build/ directory and need to clean it up first.
wyattearp
force-pushed
the
fix-update-pipx-docker
branch
from
abc6dba to
6e53e13
Compare
|
@DangerousPrototypes -- for what it's worth, both of the build did complete successfully, but it looks like the GH actions cancelled them -- you can see it got to the linking step in the logs and did what it was supposed to. |
DangerousPrototypes
merged commit 2c25f65
into
DangerousPrototypes:main
Sadly the docker build has been broken because the systems started enforcing the "don't break system packages" for pip installs.
To stay closer to the actually build instructions, I've updated to install cmake from the repo as opposed to pip, this should really be problematic because nothing fancy is happening in cmake.
Additionally, I finally took the time to setup a docker hub account to host an image. I'm happy to create a buspirate org and leave it up there, but also, I didn't want to do that without asking because it wouldn't be owned by the real maintainers :)