feat: warn about ambiguous properties/fields #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: DapperLib/Dapper#1993
added the rules:
DAP046
is reported:Properties have same name '{normalizedMemberName}' after normalization and can be conflated
example:
DAP047
is reported:Fields have same name '{normalizedMemberName}' after normalization and can be conflated
Note: I changed the locations calculations reported for properties.
For
ElementMember
representingpublic string Name { get; set; }
property, callingmember.GetLocation()
will returnSpan
, wrapping the whole property definition (including modifiers, getter and setter).I thought that standard way of reporting errors is to link the diagnostic with the member name. For example (not related to Dapper) - duplicate property names of type:
So I decided to bring such a consistency to the diagnostics. Also fields are reported only on the names (not the full field definition). Let me know if that change should be reverted
Closes #65