Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple gear adjustments #276

Merged
merged 10 commits into from
Jan 18, 2025
Merged

Conversation

linuxchr
Copy link
Contributor

The List

  • Removing Netherite, Steel, Rose Gold, Enderium, Quartzt and Enderium Gear (they all have no uses)
  • Adding a Immersive Press recipie to the Signalum Gear
  • Adding Machien Recipies to Lapis and Diamond Gears

@Darkosto
Copy link
Contributor

I would like to request that any outputs on the recipes should be specifically that item rather than using a tag. Tags outputs have a chance to be buggy and cause issues. If we're attempting to unify things, we should just be pointing directly to an item id:

{
  "type": "immersiveengineering:metal_press",
  "energy": 2400,
  "input": {
    "base_ingredient": { "tag": "forge:gems/diamond" },
    "count": 4
  },
  "mold": "immersiveengineering:mold_gear",
  "result": { "item": "thermal:diamond_gear" }
}

@Darkosto Darkosto added the Needs Changes Changes needed in Pull Request before merge label Jan 14, 2025
@linuxchr
Copy link
Contributor Author

linuxchr commented Jan 14, 2025

I agree with the choiche to use Items instead of Tags.
I only chose tags instead of items because the default immersive recipies do it, look at the default iron_gear recipie when you extract the mod file.
The requested changes were made.

@Darkosto Darkosto merged commit b530b96 into DarkPacks:develop Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Changes Changes needed in Pull Request before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants