Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent guides take on comment face #77

Open
ColemanGariety opened this issue Mar 23, 2020 · 3 comments
Open

Indent guides take on comment face #77

ColemanGariety opened this issue Mar 23, 2020 · 3 comments
Labels

Comments

@ColemanGariety
Copy link

Commenting-out an indented block gives the indent guides the font-lock-comment-face. Thus unless your font-lock-comment-face is the same as your highlight-indent-guides-*-face, it will appear as thought comments have vertical lines. Seems confusing and non-standard.

@ColemanGariety ColemanGariety changed the title Hide indent guides in comments Indent guides take on comment face Mar 23, 2020
@ColemanGariety
Copy link
Author

This seems to be the opposite of #71 because, if I understand correctly, the guides do not take on the color of the selection, and so they stand out unnecessarily?

@DarthFennec
Copy link
Owner

#71 is about how guides show through selection backgrounds, which is intended behavior. Your issue is not intended: the mode is written to completely remove guides from inside a comment when you add comment delimiters, and the same goes for strings. Does this happen only in specific situations, or any time you make a comment around guides? Does it work properly for you if you use an empty emacs configuration, where only this mode is loaded? There might be some conflict in your configuration that's causing it. Thanks for reaching out!

DarthFennec pushed a commit that referenced this issue Jun 19, 2020
* #84, Add some test environment

* #77, Indent guides take on comment face

Emacs Lisp test-cases added
@FabriceSalvaire
Copy link

I observed an issue when we comment these lines (M-x comment-region)

(defun foo ()
  ...) 

->

;; (defun foo ()
;; |  ...) 

I also observed this issue with copy-paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants