forked from DS-Homebrew/NesDS
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge FluBBa's improvements from main #4
Open
Dartz150
wants to merge
18
commits into
Dartz150:feature/Better-Sound
Choose a base branch
from
DS-Homebrew:master
base: feature/Better-Sound
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes for mappers.
Also fixed sound not working at all.
* Added support for different models of the RP2C02 chip. * Cleaned up some redundant variables.
- Remove uploading to TWLBot - Remove Discord webhook temporarily until a non-TWLBot solution is found
- No one ever updates this - One should not be using git as a binary release mechanism
- Remove useless copying to ~/artifacts/ - Remove usage of 7z - There are a grand total of two files in there - upload-artifact will zip it anyway - Remove apt installs, this project doesn't use python, and now doesn't use 7z - Restrict current workflow to master branch only - Do not trigger on release either, it's a no-op as it is
This fixes the background in Punch-Out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.