Merge pull request #1911 from sheyll/development

Fix TypeError in the segments update code
Dash-Industry-Forum · Jun 2, 2017 · c7c7c65 · c7c7c65
2 parents d793c75 + d8760d2
commit c7c7c65
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/dash/DashHandler.js b/src/dash/DashHandler.js
@@ -229,15 +229,14 @@ function DashHandler(config) {
 
         if (segments && segments.length > 0) {
             earliestTime = isNaN(earliestTime) ? segments[0].presentationStartTime : Math.min(segments[0].presentationStartTime,  earliestTime);
-        }
-
-        if (isDynamic && isNaN(timelineConverter.getExpectedLiveEdge())) {
-            const lastSegment = segments[segments.length - 1];
-            const liveEdge = lastSegment.presentationStartTime;
-            const metrics = metricsModel.getMetricsFor('stream');
-            // the last segment is the Expected, not calculated, live edge.
-            timelineConverter.setExpectedLiveEdge(liveEdge);
-            metricsModel.updateManifestUpdateInfo(dashMetrics.getCurrentManifestUpdate(metrics), {presentationStartTime: liveEdge});
+            if (isDynamic && isNaN(timelineConverter.getExpectedLiveEdge())) {
+                const lastSegment = segments[segments.length - 1];
+                const liveEdge = lastSegment.presentationStartTime;
+                const metrics = metricsModel.getMetricsFor('stream');
+                // the last segment is the Expected, not calculated, live edge.
+                timelineConverter.setExpectedLiveEdge(liveEdge);
+                metricsModel.updateManifestUpdateInfo(dashMetrics.getCurrentManifestUpdate(metrics), {presentationStartTime: liveEdge});
+            }
         }
     }