Update reset functions #1897
Merged
Update reset functions #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
Update_reset_functions
branch
2 times, most recently
from
0ab96f1 to
1a64250
Compare
nicosang
force-pushed
the
Update_reset_functions
branch
from
1a64250 to
734e000
Compare
nicosang
force-pushed
the
Update_reset_functions
branch
from
734e000 to
361a9de
Compare
nicosang
force-pushed
the
Update_reset_functions
branch
3 times, most recently
from
4772dfc to
1d2c5ca
Compare
…unction is called only once in order to get references on singleton objects. At the end of setup function, a call to reset is done to initialize attributes. When the user switchs to a new video stream, only attributes need to be reseted by a call to reset function.
…unction is called only once in order to get references on singleton objects. At the end of setup function, a call to reset is done to initialize attributes. When the user switchs to a new video stream, only attributes need to be reseted by a call to reset function.
…unction is called only once in order to get references on singleton objects. At the end of setup function, a call to reset is done to initialize attributes. When the user switchs to a new video stream, only attributes need to be reseted by a call to reset function.
…commits, this setup has to call reset function
…ed for all the different video streams.
nicosang
force-pushed
the
Update_reset_functions
branch
from
6e38ede to
09ab96b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in some files, the reset function was calling the setup function :
The main consequence was an unnecessary call to getInstance function when the user changed the video stream. So, I propose to do the reverse : setup function calls the reset. The setup function only calls the different getInstance reference. The others attributes are initialized in the reset function.
Nicolas