Update setup and reset functions #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
reset_initialize_update
branch
from
f91b4db to
4c591ac
Compare
nicosang
force-pushed
the
reset_initialize_update
branch
4 times, most recently
from
1752cb9 to
e6c7c01
Compare
…d by setup and reset functions
…e called by setup and reset functions
…alled by setup and reset functions
…to be called by setup and reset functions
…setup and reset functions
nicosang
force-pushed
the
reset_initialize_update
branch
from
e6c7c01 to
27f6cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to standardize the initialization of attributes in classes. In several classes, setup and reset function initialized same attributes. So, I purpose to let reset function do the job : setup function calls reset.
Sometimes, for unregistering events for instance, it was not possible : a resetInitialSettings has been created.
Nicolas