Add support for Infineon I2C TPM1.2 chip #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callers just fail on this error instead of retrying, so retry here as request is likely to succeed on the next try. Signed-off-by: Sergii Dmytruk <[email protected]>
To allow marking TPM with version it supports. Signed-off-by: Sergii Dmytruk <[email protected]>
Only SHA-1 is supported by TPM 1.2, so the function will pick that hash from those passed to tpmCmdPcrExtend2Hash() and fail if SHA-1 is not present. This is the only command actually used by skiboot. The only other one that can be issued is PCR Read, but that's done only for debug dumps. Several others which are implemented are never invoked. Signed-off-by: Sergii Dmytruk <[email protected]>
Might actually work for SLB9535 as well. This is a Nuvoton driver slightly modified for Infineon: - use different offsets - removed workarounds for Nuvoton - discard 0xff status as coreboot does - 3-byte burst count (0xffffff is also discarded) The differences aren't drastic and both drivers can be merged in some form, but it seemed simpler to copy and modify without touching Nuvoton driver. Signed-off-by: Sergii Dmytruk <[email protected]>
|
@SergiiDmytruk did you forgot to push? I don't see any new changes. |
SergiiDmytruk
force-pushed
the
infineon_i2c_tpm12
branch
from
00201ca to
dc1d225
Compare
|
@krystian-hebel, sorry, I pushed it to a wrong remote. |
krystian-hebel
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in commit messages.