-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-1143: Passthrough APIs for support requests and content uploads #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtong
requested review from
snf2ye and
s-rubenstein
and removed request for
a team
January 16, 2025 15:00
snf2ye
approved these changes
Jan 16, 2025
s-rubenstein
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pshapiro4broad
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, with a few comments
src/main/java/org/broadinstitute/consent/http/service/SupportRequestService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/resources/SupportResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/resources/SupportResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/resources/SupportResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/resources/SupportResource.java
Outdated
Show resolved
Hide resolved
src/test/java/org/broadinstitute/consent/http/resources/SupportResourceTest.java
Show resolved
Hide resolved
src/test/java/org/broadinstitute/consent/http/resources/SupportResourceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/models/support/TicketFields.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/models/support/TicketFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/consent/http/models/support/TicketFactory.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1143
Summary
This PR adds two APIs that act as passthroughs to Zendesk's Request API service. The intention here is to approximate what the UI expects in terms of response codes and objects. There are some minor changes to reduce the scope of what the UI needs to do in terms of parsing responses, but in general, it hews fairly close to what Zendesk returns.
See also: DataBiosphere/duos-ui#2768
Testing
To test sending a real ticket to Zendesk, update your local
consent.yaml
config value:The
Support
APIs are not authenticated so can be easily tested in swagger.Have you read CONTRIBUTING.md lately? If not, do that first.