Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1143: Passthrough APIs for support requests and content uploads #2448

Merged
merged 17 commits into from
Jan 22, 2025

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jan 14, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-1143

Summary

This PR adds two APIs that act as passthroughs to Zendesk's Request API service. The intention here is to approximate what the UI expects in terms of response codes and objects. There are some minor changes to reduce the scope of what the UI needs to do in terms of parsing responses, but in general, it hews fairly close to what Zendesk returns.

See also: DataBiosphere/duos-ui#2768

Testing

To test sending a real ticket to Zendesk, update your local consent.yaml config value:

services:
  ...
  activateSupportNotifications: true

The Support APIs are not authenticated so can be easily tested in swagger.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review January 16, 2025 15:00
@rushtong rushtong requested a review from a team as a code owner January 16, 2025 15:00
@rushtong rushtong requested review from snf2ye and s-rubenstein and removed request for a team January 16, 2025 15:00
Copy link

@s-rubenstein s-rubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pshapiro4broad pshapiro4broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, with a few comments

@rushtong rushtong merged commit 5ec63c2 into develop Jan 22, 2025
14 checks passed
@rushtong rushtong deleted the gr-DT-1143-apis branch January 22, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants