Dynamically determine bucket size for histograms #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alahwa
suggested changes
Jul 24, 2018
| @@ -14,6 +14,7 @@ | |||
| from elasticsearch_dsl import HistogramFacet | |||
There was a problem hiding this comment.
I think this is fine as a patch for some of the data we currently have, however it won't address numbers much larger than 100, and won't take into account the distribution of the data.
api/data_explorer/__main__.py
Outdated
| # is fixed, use AutoHistogramFacet instead. Will no longer need 2 | ||
| # steps. | ||
| # Step 1: Get max value | ||
| response = Search( |
There was a problem hiding this comment.
Could you write a test for this?
There was a problem hiding this comment.
If it were easy to test, I would. But it's not easy, and this is throw-away code, so I'd rather not add a test...
alahwa
reviewed
Jul 24, 2018
| # Elasticsearch won't do this for us | ||
| # (https://github.com/elastic/elasticsearch/issues/9572). Make the | ||
| # ranges easy to read (10-19,20-29 instead of 10-17,18-25). | ||
| # Creating this facet is a two-step process. |
There was a problem hiding this comment.
Since this function is getting pretty long and has substeps and sub-documentation, split out to helper methods _get_max_value and _get_bucket_size?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for NHS. Note that I don't want to put too much effort into this, because all this will go away after elastic/elasticsearch#31828 is fixed.