[DT-996] Add auth domain selection to create full view snapshot #1748
Conversation
s-rubenstein
requested review from
pshapiro4broad and
snf2ye
and removed request for
a team
| import TerraTooltip from './TerraTooltip'; | ||
| import JadeDropdown from '../dataset/data/JadeDropdown'; | ||
| import { useOnMount } from '../../libs/utils'; | ||
|
|
||
| interface FullViewSnapshotButtonProps { | ||
| const styles = (theme: CustomTheme) => |
There was a problem hiding this comment.
I would love to do this in the new style mechanism, so that is tbd
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
sr/dt-996-auth-domain-snapshot
|
| Run status |
|
| Run duration | 02m 55s |
| Commit |
|
| Committer | Sky Rubenstein |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
| value={selectedAuthDomain || ''} | ||
| /> | ||
| <div> | ||
| Authorization Domains restrict data access to only specified individuals in a group and |
There was a problem hiding this comment.
The swagger API has a warning in bold: *** WARNING - Once this is set it cannot be modified ***
Should this have a warning too?
There was a problem hiding this comment.
I was mainly following the UX set out in the ticket, maybe we can bring this up in standup?
| disabled={groups ? groups.length <= 1 : true} | ||
| options={groups ? groups.map((group) => group.groupName) : []} |
There was a problem hiding this comment.
Minor style question, does TDR UI prefer ?: over || and &&? For example
disabled={!(groups?.length > 1)}
options={groups?.map((group) => group.groupName) || []}
| htmlFor="authorization-domain-select" | ||
| > | ||
| Authorization Domain | ||
| <span style={{ fontWeight: 400, color: 'black' }}> - (optional)</span> |
There was a problem hiding this comment.
Is the use of (optional) consistent with other optional vs required inputs in TDR UI? I didn't see it used elsewhere in the code.
| @@ -972,6 +974,23 @@ export function* getFeatures(): any { | |||
| } | |||
| } | |||
|
|
|||
| export function* getUserGroups(): any { | |||
There was a problem hiding this comment.
could you reuse and maybe rename the getFeatures() call? instead of having two of the same API calls?
|
No description provided.