Skip to content

Commit

Permalink
try passing all required user object fields according to amundsen-io#296
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrea Callarelli authored and Hans Adriaans committed Jun 30, 2022
1 parent 50800f7 commit e950eb6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion metadata/metadata_service/api/user.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def get(self, *, id: Optional[str] = None) -> Iterable[Union[Mapping, int, None]
# TODO: For users that are not yet registered in Neptune, the ID seems to be null.
# Verify this.
user_data = app.config['USER_DETAIL_METHOD'](id)
LOGGER.exception(f'UserDetailAPI GET Succeeded: {user_data}')
LOGGER.info(f'UserDetailAPI GET Succeeded: {user_data}')
return UserSchema().dump(user_data), HTTPStatus.OK
except Exception:
LOGGER.exception('UserDetailAPI GET Failed - Using "USER_DETAIL_METHOD" config variable')
Expand Down
6 changes: 4 additions & 2 deletions metadata/metadata_service/flask_user_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ def get_user_from_identity_provider(user_id: str) -> Dict:
return {
"email": user_id,
"user_id": user_id,
"full_name": user_id
"full_name": user_id,
"display_name": user_id
}


Expand Down Expand Up @@ -55,7 +56,8 @@ def get_user_details(user_id: str) -> Dict:
return {
"email": user_id,
"user_id": user_id,
"full_name": user_id
"full_name": user_id,
"display_name": user_id
}


Expand Down

0 comments on commit e950eb6

Please sign in to comment.