Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding method to the caching key to make it more unique #17

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Adding method to the caching key to make it more unique #17

merged 1 commit into from
Apr 10, 2024

Conversation

netcode
Copy link
Member

@netcode netcode commented Mar 18, 2024

Fix for issue #15

d-niu
d-niu reviewed Mar 18, 2024
View reviewed changes
Copy link

@d-niu d-niu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal for the key to be unique to different types of request methods or unique per instance of the method?

@netcode
Copy link
Member Author

netcode commented Mar 19, 2024 •
edited
Loading

@d-niu

Is the goal for the key to be unique to different types of request methods or unique per instance of the method?

unique per method and shared across instance.

udgover
udgover approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@udgover udgover merged commit 1f7f799 into main Apr 10, 2024
1 check passed
@udgover udgover deleted the eslam.salem/fix-caching-issue branch April 10, 2024 16:30
@netcode netcode mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udgover udgover udgover approved these changes

@d-niu d-niu d-niu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netcode @udgover @d-niu