Merge pull request #236 from DataDog/kbogtob/improve-ansible-score

Improving Ansible score by removing bad practises

.circleci/config.yml

@@ -238,4 +238,3 @@ workflows:
       - centos_28_5
       - centos_28_6
       - centos_28_7
-

tasks/integration.yml

@@ -41,6 +41,7 @@
 
 - name: Removing integrations (Windows)
   win_command: "\"{{ datadog_agent_binary_path }}\" integration remove {{ item.key }}"
+  become: yes
   become_user: "{{ integration_command_user }}"
   loop: "{{ datadog_integration|dict2items }}"
   when: item.value.action == "remove" and ansible_os_family == "Windows"
@@ -61,6 +62,7 @@
 
 - name: Install pinned version of integrations (Windows)
   win_command: "\"{{ datadog_agent_binary_path }}\" integration install {{ item.key }}=={{ item.value.version }}"
+  become: yes
   become_user: "{{ integration_command_user }}"
   loop: "{{ datadog_integration|dict2items }}"
   when: item.value.action == "install" and ansible_os_family == "Windows"

tasks/pkg-suse.yml

@@ -6,9 +6,9 @@
       path: /tmp/DATADOG_RPM_KEY.public
     register: ddkey
   - name: Download RPM key (SLES11)
-    shell: "curl {{ datadog_zypper_gpgkey }} -o /tmp/DATADOG_RPM_KEY.public"
-    args:
-      warn: no
+    get_url:
+      url: "{{ datadog_zypper_gpgkey }}"
+      dest: /tmp/DATADOG_RPM_KEY.public
     when: not ddkey.stat.exists
   when: datadog_agent_major_version|int < 7 and ansible_distribution_version|int == 11
 
@@ -32,9 +32,9 @@
       path: /tmp/DATADOG_RPM_KEY_E09422B3.public
     register: ddnewkey
   - name: Download new RPM key (SLES11)
-    shell: "curl {{ datadog_zypper_gpgkey_e09422b3 }} -o /tmp/DATADOG_RPM_KEY_E09422B3.public"
-    args:
-      warn: no
+    get_url:
+      url: "{{ datadog_zypper_gpgkey_e09422b3 }}"
+      dest: /tmp/DATADOG_RPM_KEY_E09422B3.public
     when: not ddnewkey.stat.exists
   when: ansible_distribution_version|int == 11
 

tasks/pkg-windows-opts.yml

@@ -1,12 +1,12 @@
 - name: Set DD Username Arg
   set_fact:
     win_install_args: "{{ win_install_args }} DDAGENTUSER_NAME={{ datadog_windows_ddagentuser_name }}"
-  when: datadog_windows_ddagentuser_name != ""
+  when: datadog_windows_ddagentuser_name | length > 0
 
 - name: Set DD Password Arg
   set_fact:
     win_install_args: "{{ win_install_args }} DDAGENTUSER_PASSWORD={{ datadog_windows_ddagentuser_password }}"
-  when: datadog_windows_ddagentuser_password != ""
+  when: datadog_windows_ddagentuser_password | length > 0
 
 - name: Set Test
   set_fact: