Improving Ansible score #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
reviewed
Dec 20, 2019
There was a problem hiding this comment.
Nice!
Could you rebase master and fix a new warning that got added in ansible-galaxy with the recent merges (YAML_ERROR: too many blank lines (1 > 0) (empty-lines))? I think that's because of the extra blank line that got added to tasks/main.yml, as ansible-galaxy doesn't allow extra blank lines in the main file.
|
Sure! I'll do that. |
kbogtob
force-pushed
the
kbogtob/improve-ansible-score
branch
from
b8cb242 to
5964896
Compare
KSerrania
approved these changes
Dec 23, 2019
KSerrania
pushed a commit
that referenced
this pull request
Dec 23, 2019
Improving Ansible score by removing bad practises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improving the project score on Ansible-galaxy by following best practises here and there.
Motivation
We are loosing a lot of points because of linting errors. This impacts the company's image thus this effort to improve the notation. There's also metadata errors that we will fix at a later time.