Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6-beta #2883

Merged
merged 268 commits into from
Jan 9, 2025
Merged

v6-beta #2883

merged 268 commits into from
Jan 9, 2025

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Jul 22, 2024

Caution

Before merging, do not forget to re-enable commented out ci jobs:

  • unit-bs
  • e2e-bs
  • check-staging-merge

Motivation

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 91.43969% with 22 lines in your changes missing coverage. Please review.

Project coverage is 93.64%. Comparing base (fc08ba7) to head (7d87e69).

Files with missing lines Patch % Lines
packages/core/test/collectAsyncCalls.ts 58.82% 7 Missing ⚠️
packages/core/src/boot/init.ts 33.33% 2 Missing ⚠️
...src/domain/configuration/transportConfiguration.ts 50.00% 2 Missing ⚠️
packages/logs/src/boot/logsPublicApi.ts 33.33% 2 Missing ⚠️
packages/rum-core/src/boot/rumPublicApi.ts 33.33% 2 Missing ⚠️
packages/rum-core/src/browser/performanceUtils.ts 0.00% 2 Missing ⚠️
...s/rum-core/test/emulate/mockPerformanceObserver.ts 90.47% 2 Missing ⚠️
packages/core/src/domain/session/sessionStore.ts 87.50% 1 Missing ⚠️
packages/rum-core/src/browser/cookieObservable.ts 50.00% 1 Missing ⚠️
...kages/rum/src/domain/record/trackers/trackInput.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
+ Coverage   93.35%   93.64%   +0.28%     
==========================================
  Files         287      288       +1     
  Lines        7795     7599     -196     
  Branches     1763     1730      -33     
==========================================
- Hits         7277     7116     -161     
+ Misses        518      483      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Jul 22, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.72 KiB 144.54 KiB -17595 B -10.62%
Logs 56.17 KiB 51.13 KiB -5164 B -8.98%
Rum Slim 111.77 KiB 103.39 KiB -8587 B -7.50%
Worker 24.54 KiB 24.50 KiB -47 B -0.19%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 -0.001
addaction 0.043 0.048 0.005
addtiming 0.001 0.001 -0.000
adderror 0.052 0.048 -0.004
startstopsessionreplayrecording 1.602 0.008 -1.594
startview 0.493 0.379 -0.114
logmessage 0.038 0.019 -0.019
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 10.89 KiB 28.10 KiB 17.21 KiB
addaction 42.11 KiB 54.84 KiB 12.73 KiB
addtiming 7.02 KiB 26.14 KiB 19.12 KiB
adderror 45.65 KiB 59.70 KiB 14.05 KiB
startstopsessionreplayrecording 5.89 KiB 27.52 KiB 21.63 KiB
startview 421.68 KiB 413.33 KiB -8549 B
logmessage 41.51 KiB 60.70 KiB 19.19 KiB

🔗 RealWorld

@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration: starting soon, median merge time is 12m

Commit 612c73e5bd will soon be integrated into staging-30.

Use /to-staging -c to cancel this operation!

dd-devflow bot added a commit that referenced this pull request Jul 25, 2024
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 25, 2024

🚨 Branch Integration: This merge request has conflicts

We couldn't automatically merge the commit 612c73e5bd into staging-30!

You can use this resolution PR: #2893 to fix the conflicts.

If you need support, contact us on Slack #devflow with those details!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration: starting soon, median merge time is 12m

Commit 612c73e5bd will soon be integrated into staging-30.

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 25, 2024

🚂 Branch Integration

Commit 612c73e5bd has been merged into staging-30 in merge commit a6a057e8da.

Check out the triggered pipeline on Gitlab 🦊

@thomas-lebeau thomas-lebeau force-pushed the v6 branch 2 times, most recently from 1ab31a8 to 612c73e Compare July 25, 2024 15:14
@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 26, 2024

🚂 Branch Integration: starting soon, median merge time is 11m

Commit a6fc9ff046 will soon be integrated into staging-30.

Use /to-staging -c to cancel this operation!

dd-devflow bot added a commit that referenced this pull request Jul 26, 2024
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 26, 2024

🚨 Branch Integration: This merge request has conflicts

We couldn't automatically merge the commit a6fc9ff046 into staging-30!

You can use this resolution PR: #2896 to fix the conflicts.

If you need support, contact us on Slack #devflow with those details!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 26, 2024

🚂 Branch Integration: starting soon, median merge time is 11m

Commit a6fc9ff046 will soon be integrated into staging-30.

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 26, 2024

🚂 Branch Integration

Commit a6fc9ff046 has been merged into staging-30 in merge commit ab08076032.

Check out the triggered pipeline on Gitlab 🦊

dd-devflow bot and others added 22 commits December 23, 2024 02:14
* ✨ sanitize RegExp and Event
* 👌 review comments
* Remove anonymous user ff and fix tests

* Fix e2e bs tests

* Add opt-out configuration parameter

* Improve test cases and simplify code
* Remove anonymous user ff and fix tests

* Fix e2e bs tests

* Add opt-out configuration parameter

* Improve test cases and simplify code

* Improve anonymous uuid generation and testing

* Improve test conditions on session id
@thomas-lebeau thomas-lebeau marked this pull request as ready for review January 8, 2025 14:40
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner January 8, 2025 14:40
@@ -226,6 +226,16 @@
- ♻️ [RUM-6180] Use performanceObserver for long-task entries ([#2989](https://github.com/DataDog/browser-sdk/pull/2989)) [RUM] [RUM-SLIM]
- ⚗️✨ [RUM 5983] Add set view context apis ([#2967](https://github.com/DataDog/browser-sdk/pull/2967)) [LOGS] [RUM] [RUM-SLIM] [WORKER]

## v6.0.0-alpha.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜 nitpick: ‏this is out-of-order but also missing lots of things, let's update it when doing the release

@@ -16,6 +16,13 @@ type ContainerElementToProcess = {
path: string
}

type sanitizedEvent = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜 nitpick: ‏We need a lint rule to make sure types are always UpperCamelCased

@thomas-lebeau thomas-lebeau changed the title [WIP] v6-beta v6-beta Jan 9, 2025
@thomas-lebeau thomas-lebeau merged commit 7512878 into main Jan 9, 2025
18 checks passed
@thomas-lebeau thomas-lebeau deleted the v6 branch January 9, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants