Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React RUM] Add a ReactComponentTracker component #3086
[React RUM] Add a ReactComponentTracker component #3086
Changes from all commits
5407cc3
d1ca10e
131ef71
51dec02
eebe16b
f9325ae
19cb0a6
718555e
ea3b972
53727a6
fd3e751
a235e65
b133613
aec4b0e
821a48a
f32a7e3
60e137d
4801b50
2f5fbd3
cccd572
8c06562
5e57074
c2c51a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good approach! It's a bit unfortunate that no timing information for the reconciliation phase is captured (unless I misunderstand something), but that's admittedly a bit harder to capture, since there are no natural callbacks to hook into. At some point in the future, it might be nice to see if we can hook into the profiler hooks that
ReactFiberWorkLoop
exposes internally...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we could directly use the
Profiler
:) We'll see.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @sethfowler-datadog that it would be a lot better if we could use the hooks that the dev tools use as they track everything we need.
I'm not against testing the Profiler but I still think that it will be limiting as the docs about how to use it are very poorly written and I think it will bring us support issues about people not being able to make it work properly with their build system.