Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 [RUM-6820] fix comment about performance.timing.navigationStart #3180

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Nov 27, 2024

Motivation

Edit comment about the browser support of performance.timeOrigin

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@thomas-lebeau thomas-lebeau changed the title 👷 fix comment about performance.timing.navigationStart 👷 [RUM-6820] fix comment about performance.timing.navigationStart Nov 27, 2024
@thomas-lebeau thomas-lebeau marked this pull request as ready for review November 27, 2024 15:26
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner November 27, 2024 15:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (89107f0) to head (b86e5d0).

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #3180      +/-   ##
==========================================
+ Coverage   93.56%   93.58%   +0.01%     
==========================================
  Files         279      279              
  Lines        7478     7478              
  Branches     1689     1689              
==========================================
+ Hits         6997     6998       +1     
+ Misses        481      480       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sethfowler-datadog sethfowler-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Frustrating that performance.timeOrigin can't be relied upon...

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 151.96 KiB 151.96 KiB 0 B 0.00%
Logs 50.76 KiB 50.76 KiB 0 B 0.00%
Rum Slim 102.16 KiB 102.16 KiB 0 B 0.00%
Worker 25.16 KiB 25.16 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.001 -0.000
addaction 0.042 0.036 -0.005
addtiming 0.001 0.001 -0.000
adderror 0.037 0.040 0.003
startstopsessionreplayrecording 0.895 0.837 -0.058
startview 1.337 0.913 -0.425
logmessage 0.020 0.021 0.000
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.88 KiB 9.19 KiB 315 B
addaction 41.79 KiB 41.26 KiB -536 B
addtiming 8.35 KiB 7.33 KiB -1045 B
adderror 44.47 KiB 45.22 KiB 767 B
startstopsessionreplayrecording 5.29 KiB 6.31 KiB 1.03 KiB
startview 406.69 KiB 406.03 KiB -672 B
logmessage 41.53 KiB 42.65 KiB 1.13 KiB

🔗 RealWorld

@thomas-lebeau thomas-lebeau merged commit 3485ca5 into v6 Nov 28, 2024
16 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/remove-peformance-timing branch November 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants