Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-6075] Test anonymous id on staging behind ff #3206

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Dec 9, 2024

Motivation

Add device id as anonymous id in session cookie behind a feature flag.

Changes

Maintain anonymous id when session expires.
Extend cookie age.

Testing

Same as previous PR. Already tested on staging.

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@cy-moi cy-moi force-pushed the congyao/RUM-6075-device-id-test-staging branch from 007e8e6 to bd99736 Compare December 10, 2024 16:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (50b1073) to head (8961671).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3206      +/-   ##
==========================================
+ Coverage   93.43%   93.44%   +0.01%     
==========================================
  Files         282      283       +1     
  Lines        7721     7740      +19     
  Branches     1732     1744      +12     
==========================================
+ Hits         7214     7233      +19     
  Misses        507      507              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Dec 10, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.38 KiB 162.90 KiB 539 B +0.32%
Logs 55.84 KiB 56.30 KiB 470 B +0.82%
Rum Slim 110.96 KiB 111.49 KiB 539 B +0.47%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.001
addaction 0.030 0.046 0.016
addtiming 0.001 0.001 0.000
adderror 0.032 0.051 0.018
startstopsessionreplayrecording 0.907 1.047 0.140
startview 0.965 0.484 -0.481
logmessage 0.019 0.024 0.005
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.79 KiB 7.14 KiB -668 B
addaction 38.73 KiB 38.33 KiB -402 B
addtiming 7.65 KiB 6.34 KiB -1341 B
adderror 45.50 KiB 43.42 KiB -2122 B
startstopsessionreplayrecording 5.36 KiB 5.60 KiB 249 B
startview 420.91 KiB 426.62 KiB 5.71 KiB
logmessage 41.71 KiB 41.10 KiB -617 B

🔗 RealWorld

@cy-moi cy-moi force-pushed the congyao/RUM-6075-device-id-test-staging branch from bd99736 to 8961671 Compare December 10, 2024 16:11
@cy-moi
Copy link
Contributor Author

cy-moi commented Dec 11, 2024

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Dec 11, 2024

Devflow running: /to-staging

View all feedbacks in Devflow UI.


2024-12-11 12:56:15 UTC ℹ️ Branch Integration: starting soon, median merge time is 9m53s

Commit 896167162e will soon be integrated into staging-50.


2024-12-11 13:08:02 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 896167162e has been merged into staging-50 in merge commit f817a05451.

Check out the triggered pipeline on Gitlab 🦊

@cy-moi cy-moi marked this pull request as ready for review December 11, 2024 12:56
@cy-moi cy-moi requested a review from a team as a code owner December 11, 2024 12:56
dd-mergequeue bot added a commit that referenced this pull request Dec 11, 2024
@cy-moi cy-moi merged commit f87c2fe into main Dec 11, 2024
21 checks passed
@cy-moi cy-moi deleted the congyao/RUM-6075-device-id-test-staging branch December 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants