Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update eslint to v9 / flat config #3259

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 7, 2025

Motivation

Keep dependencies up to date

Changes

See Migrate to v9.x

ESLint v9 uses a new configuration format called flat config. The main change was to update to that new configuration.

ESLint now reports unused directive by default. This can be disabled, but I think this is interesting so I kept it and cleaned some unused directives.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Main changes:

* Removed a few unneeded eslint plugins
  - prefer-arrow was not used
  - local-rules isn't needed anymore with ESLint 9 (we can just import
    the files directly)
  - prettier is not useful anymore, as all the rules it disables are
    removed is ESLint 9 https://eslint.org/docs/latest/use/migrate-to-9.0.0#-function-style-rules-are-no-longer-supported

* Enable @typescript-eslint/no-empty-function: it's not in the
  recommended config anymore. Also now it catches more issues.
ESLint now warns for unused directives by default. Let's clean those up!
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (e263716) to head (f8e46fc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
+ Coverage   93.51%   93.65%   +0.14%     
==========================================
  Files         288      288              
  Lines        7599     7600       +1     
  Branches     1730     1730              
==========================================
+ Hits         7106     7118      +12     
+ Misses        493      482      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review January 7, 2025 14:00
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner January 7, 2025 14:00
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 144.58 KiB 144.58 KiB N/A%
Logs 0 B 51.09 KiB 51.09 KiB N/A%
Rum Slim 0 B 103.42 KiB 103.42 KiB N/A%
Worker 0 B 24.50 KiB 24.50 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.002 0.002
addaction N/A 0.044 0.044
addtiming N/A 0.001 0.001
adderror N/A 0.063 0.063
startstopsessionreplayrecording N/A 0.009 0.009
startview N/A 0.368 0.368
logmessage N/A 0.021 0.021
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 27.90 KiB NaN KiB
addaction NaN KiB 55.72 KiB NaN KiB
addtiming NaN KiB 25.40 KiB NaN KiB
adderror NaN KiB 58.13 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 24.89 KiB NaN KiB
startview NaN KiB 414.16 KiB NaN KiB
logmessage NaN KiB 58.03 KiB NaN KiB

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer merged commit fc1bb77 into main Jan 14, 2025
19 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/update-eslint branch January 14, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants