-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Update eslint to v9 / flat config #3259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main changes: * Removed a few unneeded eslint plugins - prefer-arrow was not used - local-rules isn't needed anymore with ESLint 9 (we can just import the files directly) - prettier is not useful anymore, as all the rules it disables are removed is ESLint 9 https://eslint.org/docs/latest/use/migrate-to-9.0.0#-function-style-rules-are-no-longer-supported * Enable @typescript-eslint/no-empty-function: it's not in the recommended config anymore. Also now it catches more issues.
ESLint now warns for unused directives by default. Let's clean those up!
BenoitZugmeyer
force-pushed
the
benoit/update-eslint
branch
from
January 7, 2025 13:19
181a371
to
b86a29a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
==========================================
+ Coverage 93.51% 93.65% +0.14%
==========================================
Files 288 288
Lines 7599 7600 +1
Branches 1730 1730
==========================================
+ Hits 7106 7118 +12
+ Misses 493 482 -11 ☔ View full report in Codecov by Sentry. |
amortemousque
approved these changes
Jan 8, 2025
sethfowler-datadog
approved these changes
Jan 8, 2025
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep dependencies up to date
Changes
See Migrate to v9.x
ESLint v9 uses a new configuration format called flat config. The main change was to update to that new configuration.
ESLint now reports unused directive by default. This can be disabled, but I think this is interesting so I kept it and cleaned some unused directives.
Testing
I have gone over the contributing documentation.