✨ [RUM-7572] Add get api of view specific context #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 287 287
Lines 7784 7789 +5
Branches 1759 1759
=======================================
+ Hits 7266 7271 +5
Misses 518 518 ☔ View full report in Codecov by Sentry. |
nulrich
reviewed
Jan 8, 2025
thomas-lebeau
approved these changes
Jan 14, 2025
| @@ -53,6 +53,8 @@ export function createPreStartStrategy( | |||
|
|
|||
| const trackingConsentStateSubscription = trackingConsentState.observable.subscribe(tryStartRum) | |||
|
|
|||
| const noopContext: Context = {} | |||
There was a problem hiding this comment.
🥜 nitpick: emptyContext is more correct I think in this case (even if indeed there is no operation too)
nulrich
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After adding set view context we need to have a get view context api
Changes
Add a new api
Testing
I have gone over the contributing documentation.