Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Better integrated logger. #109

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

yoannmoinet
Copy link
Member

@yoannmoinet yoannmoinet commented Nov 14, 2024

What and why?

Our logger is a bit simplistic, it needs to be better integrated into the ecosystem.
Especially with the build-report to report errors and warnings.
As well as a simpler initialisation for plugins.

How?

  • Move the logger factory into the global context.
  • Store all logs in build-report.
  • Fix errors/warnings in esbuild and webpack build reports.
  • Add tests.
  • Factorise some mocks.
  • Add some logs in hope to better understand test's race condition.

@yoannmoinet yoannmoinet changed the base branch from master to yoann/new-internal-plugins November 14, 2024 14:34
@yoannmoinet yoannmoinet force-pushed the yoann/refactor-logger branch from 9757247 to e546be5 Compare November 14, 2024 17:00
@yoannmoinet yoannmoinet marked this pull request as ready for review November 15, 2024 13:23
@yoannmoinet yoannmoinet requested a review from a team as a code owner November 15, 2024 13:23
@yoannmoinet yoannmoinet requested review from nchapma2 and elbywan and removed request for a team and nchapma2 November 15, 2024 13:23
Base automatically changed from yoann/new-internal-plugins to master November 18, 2024 14:32
@yoannmoinet yoannmoinet force-pushed the yoann/refactor-logger branch from 8108b2e to c96d974 Compare November 18, 2024 14:33
packages/core/src/types.ts Outdated Show resolved Hide resolved
@yoannmoinet yoannmoinet merged commit 819da60 into master Nov 20, 2024
4 checks passed
@yoannmoinet yoannmoinet deleted the yoann/refactor-logger branch November 20, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants