-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Better integrated logger. #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
changed the base branch from
master
to
yoann/new-internal-plugins
November 14, 2024 14:34
yoannmoinet
force-pushed
the
yoann/refactor-logger
branch
from
November 14, 2024 17:00
9757247
to
e546be5
Compare
yoannmoinet
requested review from
nchapma2 and
elbywan
and removed request for
a team and
nchapma2
November 15, 2024 13:23
yoannmoinet
force-pushed
the
yoann/refactor-logger
branch
from
November 18, 2024 14:33
8108b2e
to
c96d974
Compare
Ayc0
reviewed
Nov 19, 2024
Ayc0
reviewed
Nov 19, 2024
Ayc0
reviewed
Nov 19, 2024
Ayc0
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Our logger is a bit simplistic, it needs to be better integrated into the ecosystem.
Especially with the build-report to report errors and warnings.
As well as a simpler initialisation for plugins.
How?