[fix] Small fixes #114
Merged
[fix] Small fixes #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
requested review from
elbywan and
Ayc0
and removed request for
a team
Ayc0
reviewed
Nov 27, 2024
Comment on lines
371
to
372
| // Only keep JS files. | ||
| .filter((f) => getType(f) === 'js')[0]; |
There was a problem hiding this comment.
To note: if you use filter to then return the 1st element, you may want to use .find instead
There was a problem hiding this comment.
This will avoid creating a new array
Ayc0
reviewed
Nov 27, 2024
| @@ -22,6 +22,7 @@ import path from 'path'; | |||
| const EXTENSION_RX = /\.(?!.*(?:\.|\/|\\))(\w{1,})/g; | |||
|
|
|||
| // Will match any type of query characters. | |||
| // ? or %3F or |. | |||
There was a problem hiding this comment.
what is %3F?
Also you should remove the . from this comment as I first understood that as "will match |."
There was a problem hiding this comment.
%3F is ? url encoded.
There was a problem hiding this comment.
You may want to write this in the comment, as otherwise it's basically just re-writing the regex but in natural language
Ayc0
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
#112 introduced a bug in the sender of our telemetry plugin.
How?