-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rum] Inject browser sdk #119
Draft
yoannmoinet
wants to merge
6
commits into
yoann/lighten-readmes
Choose a base branch
from
yoann/inject-browser-sdk
base: yoann/lighten-readmes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
2 times, most recently
from
December 2, 2024 10:20
47ec98f
to
73486c7
Compare
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
December 9, 2024 15:29
a305acd
to
fceab29
Compare
yoannmoinet
changed the base branch from
yoann/move-sourcemaps
to
yoann/add-more-injection-points
December 9, 2024 15:29
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
December 9, 2024 16:35
fceab29
to
3c35484
Compare
yoannmoinet
force-pushed
the
yoann/add-more-injection-points
branch
from
January 14, 2025 14:23
84950be
to
74d2575
Compare
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
2 times, most recently
from
January 16, 2025 10:05
e401db0
to
d66990f
Compare
yoannmoinet
changed the base branch from
yoann/add-more-injection-points
to
yoann/better-sandbox-tests
January 16, 2025 10:05
- Also remove a warning that was coming from dts plugin
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
January 16, 2025 13:55
d66990f
to
5f3ea86
Compare
yoannmoinet
changed the base branch from
yoann/better-sandbox-tests
to
yoann/lighten-readmes
January 16, 2025 13:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Automatically inject RUM's Browser SDK into the bundle.
How?
A few updates were necessary:
doRequest
helper, so we can fetch the correctclientToken
in case the customer didn't add it to the rum's configuration.rum-browser-sdk.js
which is used for the injection.TODO