Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rum] Inject browser sdk #119

Draft
wants to merge 6 commits into
base: yoann/lighten-readmes
Choose a base branch
from

Conversation

yoannmoinet
Copy link
Member

@yoannmoinet yoannmoinet commented Nov 29, 2024

What and why?

Automatically inject RUM's Browser SDK into the bundle.

How?

A few updates were necessary:

  • Add auth to the doRequest helper, so we can fetch the correct clientToken in case the customer didn't add it to the rum's configuration.
  • Improve logger and build report with more data on the bundler.
  • Create a better isolation of the injected code using an IIFE.
  • Update the bundling mechanism of our plugins to allow side builds declared by the plugins (ex: RUM needs to pre-bundle the browser SDK file into a single file).
  • Implement the RUM plugin and add tests.
    • It also publishes a new file alongside our bundler plugins rum-browser-sdk.js which is used for the injection.

TODO

  • Test RUM's SDK in real life situation.

@yoannmoinet yoannmoinet linked an issue Nov 29, 2024 that may be closed by this pull request
@yoannmoinet yoannmoinet self-assigned this Nov 29, 2024
@yoannmoinet yoannmoinet changed the base branch from master to yoann/move-sourcemaps November 29, 2024 15:32
@yoannmoinet yoannmoinet force-pushed the yoann/inject-browser-sdk branch 2 times, most recently from 47ec98f to 73486c7 Compare December 2, 2024 10:20
@yoannmoinet yoannmoinet force-pushed the yoann/inject-browser-sdk branch from a305acd to fceab29 Compare December 9, 2024 15:29
@yoannmoinet yoannmoinet changed the base branch from yoann/move-sourcemaps to yoann/add-more-injection-points December 9, 2024 15:29
@yoannmoinet yoannmoinet force-pushed the yoann/inject-browser-sdk branch from fceab29 to 3c35484 Compare December 9, 2024 16:35
@yoannmoinet yoannmoinet force-pushed the yoann/add-more-injection-points branch from 84950be to 74d2575 Compare January 14, 2025 14:23
@yoannmoinet yoannmoinet force-pushed the yoann/inject-browser-sdk branch 2 times, most recently from e401db0 to d66990f Compare January 16, 2025 10:05
@yoannmoinet yoannmoinet changed the base branch from yoann/add-more-injection-points to yoann/better-sandbox-tests January 16, 2025 10:05
@yoannmoinet yoannmoinet force-pushed the yoann/inject-browser-sdk branch from d66990f to 5f3ea86 Compare January 16, 2025 13:55
@yoannmoinet yoannmoinet changed the base branch from yoann/better-sandbox-tests to yoann/lighten-readmes January 16, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement RUM's Browser SDK injection
1 participant