-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Refactor telemetry with build report #93
Merged
yoannmoinet
merged 29 commits into
master
from
yoann/refactor-telemetry-with-build-report
Sep 18, 2024
Merged
[Telemetry] Refactor telemetry with build report #93
yoannmoinet
merged 29 commits into
master
from
yoann/refactor-telemetry-with-build-report
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
force-pushed
the
yoann/refactor-telemetry-with-build-report
branch
from
September 5, 2024 12:20
a42ddf3
to
f86dd0f
Compare
yoannmoinet
force-pushed
the
yoann/refactor-telemetry-with-build-report
branch
from
September 9, 2024 13:23
1c288ad
to
fe073b1
Compare
elbywan
approved these changes
Sep 10, 2024
sarenji
approved these changes
Sep 10, 2024
…-telemetry-with-build-report
Miz85
approved these changes
Sep 16, 2024
Base automatically changed from
yoann/build-report-internal-plugin
to
master
September 18, 2024 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
To merge into #92
What and why?
Now that we have an universal build-report, we can refactor the telemetry module to also be universal for the most part.
How?
It's a large refactor of the telemetry module.
Removing most of the esbuild/webpack specificities.
Only remaining ones are about the tracing and reporting of plugins/loaders.
Most of the main processes have been streamlined
A lot of tests added/redone:
.toBeWithinRange
helper for Jest../setupTests.ts
file to inject the helpers and block any network request withnock
..each
to reduce footprint of some tests.It also introduces some configuration changes:
endPoint has moved in
telemetry` configuration.enbaledTracing
to run the tracing and reporting of plugins/loaders forwebpack
andesbuild
. It isfalse
by default, as it has a somewhat heavy impact on the builds.telemetry.output
has been simplified, we only write two files now.logLevel
configuration on theinfo
channel.Update of the text report:
Fixes #79