Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jmx.yaml.erb file has a small typo which causes it to ignore attributes. This fixes that issue. I didn't notice any tests for the jmx.yaml file...
I also realized that the structure of the yaml file doesn't appear to fully support both invocations of the attributes referenced here.
I was thinking it would be helpful if the attributes key could be an array or a hash. The array would be a list of strings, naming attributes. The hash would be a hash of hashes, the key would define the attribute, and the hash would define the metric type and alias. If that's agreeable, I could add that to this PR or make a separate one (and update the Vagrantfile).