[devcontainer] Update cmake to detect Python 3.12 #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the
devcontainerto usecmake3.30.2(like the other build images) instead of the stock version bundled in Ubuntu 22.04 (3.22.1).Motivation
This is necessary to ensure
cmakedetects Python 3.12, for the same reasons as #642.Possible Drawbacks / Trade-offs
Adds more manual steps.
Another alternative would be to update the container's base to
ubuntu:24.04(bundles Python 3.12 + a more recentcmakeversion), but this is a larger change that may require additional updates.Additional Notes
I tested by running the
inv agent.build --run-on linuxcommand, targeting a devcontainer built locally on this branch. Before merging, I'd like for someone else to test the main Agent commands in it.