Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Prevent skipping and use correct image version #746

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(test): Prevent skipping and use correct image version #746

merged 1 commit into from
Jan 20, 2025

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jan 20, 2025 •
edited
Loading

What does this PR do?

  • Put the trigger_build_kernels and trigger_tests in the same stage
  • Pass the correct image version to the trigger_build_kernels part

Motivation

  • Because of the "default" dependency mechanism of gitlab, the trigger_tests was skipped if the trigger_build_kernels was not run or failed
    image
    image

  • The trigger_build_kernels was failing because the image version was missing the commit sha

ERROR: Job failed: failed to pull image "registry.ddbuild.io/ci/datadog-agent-buildimages/kernel-version-testing_x64_test_only:v53412678" with specified policies

Tests

  • Now the trigger_build_kernels are running
  • The trigger_test is no more skipped

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested a review from a team as a code owner January 20, 2025 09:02
@chouetz chouetz merged commit 1393a40 into main Jan 20, 2025
107 checks passed
@chouetz chouetz deleted the nschweitzer/jobs branch January 20, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CelianR CelianR CelianR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chouetz @CelianR