Skip to content

Commit

Permalink
[APR-258] Add option to compress logs with zstd (#27148)
Browse files Browse the repository at this point in the history
Co-authored-by: jszwedko <[email protected]>
Co-authored-by: remeh <[email protected]>
  • Loading branch information
3 people authored Jan 16, 2025
1 parent 4193d01 commit 96d253e
Show file tree
Hide file tree
Showing 160 changed files with 2,393 additions and 887 deletions.
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,8 @@
/comp/haagent @DataDog/ndm-core
/comp/languagedetection/client @DataDog/container-platform
/comp/rdnsquerier @DataDog/ndm-integrations
/comp/serializer/compression @DataDog/agent-metrics-logs
/comp/serializer/logscompression @DataDog/agent-processing-and-routing
/comp/serializer/metricscompression @DataDog/agent-processing-and-routing
/comp/snmpscan @DataDog/ndm-core
# END COMPONENTS

Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ workflow:
- comp/dogstatsd/**/*
- comp/forwarder/**/*
- comp/logs/**/*
- comp/serializer/compression/**/*
- comp/serializer/**/*
- pkg/aggregator/**/*
- pkg/collector/**/*
- pkg/commonchecks/**/*
Expand Down
6 changes: 4 additions & 2 deletions cmd/agent/subcommands/diagnose/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ import (
workloadmeta "github.com/DataDog/datadog-agent/comp/core/workloadmeta/def"
workloadmetafx "github.com/DataDog/datadog-agent/comp/core/workloadmeta/fx"
haagentfx "github.com/DataDog/datadog-agent/comp/haagent/fx"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
logscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
"github.com/DataDog/datadog-agent/pkg/api/util"
pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup"
"github.com/DataDog/datadog-agent/pkg/diagnose"
Expand Down Expand Up @@ -104,9 +105,10 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
fx.Supply(option.None[collector.Component]()),
dualTaggerfx.Module(common.DualTaggerParams()),
autodiscoveryimpl.Module(),
compressionfx.Module(),
diagnosesendermanagerimpl.Module(),
haagentfx.Module(),
logscompressorfx.Module(),
metricscompressorfx.Module(),
)
},
}
Expand Down
6 changes: 4 additions & 2 deletions cmd/agent/subcommands/flare/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ import (
"github.com/DataDog/datadog-agent/comp/metadata/inventoryhost/inventoryhostimpl"
"github.com/DataDog/datadog-agent/comp/metadata/inventoryotel/inventoryotelimpl"
"github.com/DataDog/datadog-agent/comp/metadata/resources/resourcesimpl"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
logscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
"github.com/DataDog/datadog-agent/pkg/api/util"
"github.com/DataDog/datadog-agent/pkg/config/settings"
pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup"
Expand Down Expand Up @@ -131,7 +132,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
localTaggerfx.Module(tagger.Params{}),
autodiscoveryimpl.Module(),
fx.Supply(option.None[collector.Component]()),
compressionfx.Module(),
diagnosesendermanagerimpl.Module(),
// We need inventoryagent to fill the status page generated by the flare.
inventoryagentimpl.Module(),
Expand All @@ -147,6 +147,8 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
}),
core.Bundle(),
haagentfx.Module(),
logscompressorfx.Module(),
metricscompressorfx.Module(),
)
},
}
Expand Down
6 changes: 4 additions & 2 deletions cmd/agent/subcommands/jmx/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ import (
integrations "github.com/DataDog/datadog-agent/comp/logs/integrations/def"
"github.com/DataDog/datadog-agent/comp/remote-config/rcservice"
"github.com/DataDog/datadog-agent/comp/remote-config/rcservicemrf"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
logscompression "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompression "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
"github.com/DataDog/datadog-agent/pkg/aggregator/sender"
"github.com/DataDog/datadog-agent/pkg/cli/standalone"
pkgcollector "github.com/DataDog/datadog-agent/pkg/collector"
Expand Down Expand Up @@ -129,7 +130,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
fx.Supply(cliParams),
fx.Supply(params),
core.Bundle(),
compressionfx.Module(),
diagnosesendermanagerimpl.Module(),
fx.Supply(func(diagnoseSenderManager diagnosesendermanager.Component) (sender.SenderManager, error) {
return diagnoseSenderManager.LazyGetSenderManager()
Expand Down Expand Up @@ -168,6 +168,8 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
}),
fx.Provide(func() remoteagentregistry.Component { return nil }),
haagentfx.Module(),
logscompression.Module(),
metricscompression.Module(),
)
}

Expand Down
4 changes: 2 additions & 2 deletions cmd/agent/subcommands/run/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import (
agenttelemetry "github.com/DataDog/datadog-agent/comp/core/agenttelemetry/def"
agenttelemetryfx "github.com/DataDog/datadog-agent/comp/core/agenttelemetry/fx"
haagentfx "github.com/DataDog/datadog-agent/comp/haagent/fx"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"

// checks implemented as components

Expand Down Expand Up @@ -124,6 +123,7 @@ import (
"github.com/DataDog/datadog-agent/comp/remote-config/rcservice/rcserviceimpl"
"github.com/DataDog/datadog-agent/comp/remote-config/rcservicemrf/rcservicemrfimpl"
"github.com/DataDog/datadog-agent/comp/remote-config/rctelemetryreporter/rctelemetryreporterimpl"
metricscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
"github.com/DataDog/datadog-agent/comp/snmptraps"
snmptrapsServer "github.com/DataDog/datadog-agent/comp/snmptraps/server"
traceagentStatusImpl "github.com/DataDog/datadog-agent/comp/trace/status/statusimpl"
Expand Down Expand Up @@ -380,7 +380,6 @@ func getSharedFxOption() fx.Option {
authtokenimpl.Module(),
apiimpl.Module(),
commonendpoints.Module(),
compressionfx.Module(),
demultiplexerimpl.Module(demultiplexerimpl.NewDefaultParams(demultiplexerimpl.WithDogstatsdNoAggregationPipelineConfig())),
demultiplexerendpointfx.Module(),
dogstatsd.Bundle(dogstatsdServer.Params{Serverless: false}),
Expand Down Expand Up @@ -474,6 +473,7 @@ func getSharedFxOption() fx.Option {
networkpath.Bundle(),
remoteagentregistryfx.Module(),
haagentfx.Module(),
metricscompressorfx.Module(),
)
}

Expand Down
9 changes: 6 additions & 3 deletions cmd/agent/subcommands/snmp/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ import (
"github.com/DataDog/datadog-agent/comp/forwarder/eventplatformreceiver/eventplatformreceiverimpl"
"github.com/DataDog/datadog-agent/comp/forwarder/orchestrator/orchestratorimpl"
haagentfx "github.com/DataDog/datadog-agent/comp/haagent/fx"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
logscompression "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompression "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
snmpscan "github.com/DataDog/datadog-agent/comp/snmpscan/def"
snmpscanfx "github.com/DataDog/datadog-agent/comp/snmpscan/fx"
"github.com/DataDog/datadog-agent/pkg/networkdevice/metadata"
Expand Down Expand Up @@ -98,10 +99,11 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
forwarder.Bundle(defaultforwarder.NewParams(defaultforwarder.WithFeatures(defaultforwarder.CoreFeatures))),
orchestratorimpl.Module(orchestratorimpl.NewDefaultParams()),
eventplatformimpl.Module(eventplatformimpl.NewDefaultParams()),
compressionfx.Module(),
nooptagger.Module(),
eventplatformreceiverimpl.Module(),
haagentfx.Module(),
metricscompression.Module(),
logscompression.Module(),
)
if err != nil {
var ue configErr
Expand Down Expand Up @@ -162,10 +164,11 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
forwarder.Bundle(defaultforwarder.NewParams(defaultforwarder.WithFeatures(defaultforwarder.CoreFeatures))),
eventplatformimpl.Module(eventplatformimpl.NewDefaultParams()),
eventplatformreceiverimpl.Module(),
compressionfx.Module(),
nooptagger.Module(),
snmpscanfx.Module(),
haagentfx.Module(),
metricscompression.Module(),
logscompression.Module(),
)
if err != nil {
var ue configErr
Expand Down
6 changes: 4 additions & 2 deletions cmd/cluster-agent-cloudfoundry/subcommands/run/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ import (
orchestratorForwarderImpl "github.com/DataDog/datadog-agent/comp/forwarder/orchestrator/orchestratorimpl"
haagentfx "github.com/DataDog/datadog-agent/comp/haagent/fx"
integrations "github.com/DataDog/datadog-agent/comp/logs/integrations/def"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
logscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
"github.com/DataDog/datadog-agent/pkg/clusteragent"
"github.com/DataDog/datadog-agent/pkg/clusteragent/clusterchecks"
pkgcollector "github.com/DataDog/datadog-agent/pkg/collector"
Expand Down Expand Up @@ -86,7 +87,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
}),
core.Bundle(),
forwarder.Bundle(defaultforwarder.NewParams(defaultforwarder.WithResolvers())),
compressionfx.Module(),
demultiplexerimpl.Module(demultiplexerimpl.NewDefaultParams()),
orchestratorForwarderImpl.Module(orchestratorForwarderImpl.NewDisabledParams()),
eventplatformimpl.Module(eventplatformimpl.NewDisabledParams()),
Expand Down Expand Up @@ -128,6 +128,8 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
proccontainers.InitSharedContainerProvider(wmeta, tagger)
}),
haagentfx.Module(),
logscompressionfx.Module(),
metricscompressionfx.Module(),
)
},
}
Expand Down
2 changes: 0 additions & 2 deletions cmd/cluster-agent/subcommands/diagnose/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"github.com/DataDog/datadog-agent/comp/core/config"
log "github.com/DataDog/datadog-agent/comp/core/log/def"
"github.com/DataDog/datadog-agent/comp/core/secrets"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
"github.com/DataDog/datadog-agent/pkg/diagnose"
"github.com/DataDog/datadog-agent/pkg/diagnose/diagnosis"
"github.com/DataDog/datadog-agent/pkg/util/fxutil"
Expand All @@ -38,7 +37,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
LogParams: log.ForOneShot(command.LoggerName, "off", true), // no need to show regular logs
}),
core.Bundle(),
compressionfx.Module(),
)
},
}
Expand Down
10 changes: 7 additions & 3 deletions cmd/cluster-agent/subcommands/start/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ import (
rccomp "github.com/DataDog/datadog-agent/comp/remote-config/rcservice"
"github.com/DataDog/datadog-agent/comp/remote-config/rcservice/rcserviceimpl"
"github.com/DataDog/datadog-agent/comp/remote-config/rctelemetryreporter/rctelemetryreporterimpl"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
logscompression "github.com/DataDog/datadog-agent/comp/serializer/logscompression/def"
logscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
"github.com/DataDog/datadog-agent/pkg/clusteragent"
admissionpkg "github.com/DataDog/datadog-agent/pkg/clusteragent/admission"
admissionpatch "github.com/DataDog/datadog-agent/pkg/clusteragent/admission/patch"
Expand Down Expand Up @@ -137,7 +139,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
}),
core.Bundle(),
forwarder.Bundle(defaultforwarder.NewParams(defaultforwarder.WithResolvers(), defaultforwarder.WithDisableAPIKeyChecking())),
compressionfx.Module(),
demultiplexerimpl.Module(demultiplexerimpl.NewDefaultParams()),
orchestratorForwarderImpl.Module(orchestratorForwarderImpl.NewDefaultParams()),
eventplatformimpl.Module(eventplatformimpl.NewDisabledParams()),
Expand Down Expand Up @@ -204,6 +205,8 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
proccontainers.InitSharedContainerProvider(wmeta, tagger)
}),
haagentfx.Module(),
logscompressionfx.Module(),
metricscompressionfx.Module(),
)
},
}
Expand All @@ -226,6 +229,7 @@ func start(log log.Component,
logReceiver option.Option[integrations.Component],
_ healthprobe.Component,
settings settings.Component,
compression logscompression.Component,
datadogConfig config.Component,
) error {
stopCh := make(chan struct{})
Expand Down Expand Up @@ -441,7 +445,7 @@ func start(log log.Component,
go func() {
defer wg.Done()

if err := runCompliance(mainCtx, demultiplexer, wmeta, apiCl, le.IsLeader); err != nil {
if err := runCompliance(mainCtx, demultiplexer, wmeta, apiCl, compression, le.IsLeader); err != nil {
pkglog.Errorf("Error while running compliance agent: %v", err)
}
}()
Expand Down
9 changes: 5 additions & 4 deletions cmd/cluster-agent/subcommands/start/compliance.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (

workloadmeta "github.com/DataDog/datadog-agent/comp/core/workloadmeta/def"
"github.com/DataDog/datadog-agent/comp/logs/agent/config"
logscompression "github.com/DataDog/datadog-agent/comp/serializer/logscompression/def"
"github.com/DataDog/datadog-agent/pkg/aggregator/sender"
"github.com/DataDog/datadog-agent/pkg/compliance"
pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup"
Expand All @@ -31,9 +32,9 @@ const (
intakeTrackType = "compliance"
)

func runCompliance(ctx context.Context, senderManager sender.SenderManager, wmeta workloadmeta.Component, apiCl *apiserver.APIClient, isLeader func() bool) error {
func runCompliance(ctx context.Context, senderManager sender.SenderManager, wmeta workloadmeta.Component, apiCl *apiserver.APIClient, compression logscompression.Component, isLeader func() bool) error {
stopper := startstop.NewSerialStopper()
if err := startCompliance(senderManager, wmeta, stopper, apiCl, isLeader); err != nil {
if err := startCompliance(senderManager, wmeta, stopper, apiCl, isLeader, compression); err != nil {
return err
}

Expand Down Expand Up @@ -72,7 +73,7 @@ func newLogContextCompliance() (*config.Endpoints, *client.DestinationsContext,
return newLogContext(logsConfigComplianceKeys, "cspm-intake.")
}

func startCompliance(senderManager sender.SenderManager, wmeta workloadmeta.Component, stopper startstop.Stopper, apiCl *apiserver.APIClient, isLeader func() bool) error {
func startCompliance(senderManager sender.SenderManager, wmeta workloadmeta.Component, stopper startstop.Stopper, apiCl *apiserver.APIClient, isLeader func() bool, compression logscompression.Component) error {
endpoints, ctx, err := newLogContextCompliance()
if err != nil {
log.Error(err)
Expand All @@ -87,7 +88,7 @@ func startCompliance(senderManager sender.SenderManager, wmeta workloadmeta.Comp
return err
}

reporter := compliance.NewLogReporter(hname, "compliance-agent", "compliance", endpoints, ctx)
reporter := compliance.NewLogReporter(hname, "compliance-agent", "compliance", endpoints, ctx, compression)
statsdClient, err := simpleTelemetrySenderFromSenderManager(senderManager)
if err != nil {
return err
Expand Down
6 changes: 4 additions & 2 deletions cmd/dogstatsd/subcommands/start/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ import (
"github.com/DataDog/datadog-agent/comp/metadata/resources/resourcesimpl"
"github.com/DataDog/datadog-agent/comp/metadata/runner"
metadatarunnerimpl "github.com/DataDog/datadog-agent/comp/metadata/runner/runnerimpl"
compressionfx "github.com/DataDog/datadog-agent/comp/serializer/compression/fx"
logscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
"github.com/DataDog/datadog-agent/pkg/serializer"
"github.com/DataDog/datadog-agent/pkg/status/health"
"github.com/DataDog/datadog-agent/pkg/util/coredump"
Expand Down Expand Up @@ -141,7 +142,8 @@ func RunDogstatsdFct(cliParams *CLIParams, defaultConfPath string, defaultLogFil
AgentType: workloadmeta.NodeAgent,
InitHelper: common.GetWorkloadmetaInit(),
}),
compressionfx.Module(),
metricscompressionfx.Module(),
logscompressionfx.Module(),
demultiplexerimpl.Module(demultiplexerimpl.NewDefaultParams(
demultiplexerimpl.WithContinueOnMissingHostname(),
demultiplexerimpl.WithDogstatsdNoAggregationPipelineConfig(),
Expand Down
15 changes: 11 additions & 4 deletions cmd/otel-agent/subcommands/run/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import (
remoteTaggerFx "github.com/DataDog/datadog-agent/comp/core/tagger/fx-remote"
taggerTypes "github.com/DataDog/datadog-agent/comp/core/tagger/types"
"github.com/DataDog/datadog-agent/comp/core/telemetry/telemetryimpl"

workloadmeta "github.com/DataDog/datadog-agent/comp/core/workloadmeta/def"
workloadmetafx "github.com/DataDog/datadog-agent/comp/core/workloadmeta/fx"
"github.com/DataDog/datadog-agent/comp/dogstatsd/statsd"
Expand All @@ -48,7 +47,9 @@ import (
"github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline/logsagentpipelineimpl"
"github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/serializerexporter"
"github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient"
compressionfxzlib "github.com/DataDog/datadog-agent/comp/serializer/compression/fx-zlib"
logscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
metricscompression "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/def"
metricscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx-otel"
traceagentfx "github.com/DataDog/datadog-agent/comp/trace/agent/fx"
traceagentcomp "github.com/DataDog/datadog-agent/comp/trace/agent/impl"
gzipfx "github.com/DataDog/datadog-agent/comp/trace/compression/fx-gzip"
Expand All @@ -58,6 +59,7 @@ import (
pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup"
"github.com/DataDog/datadog-agent/pkg/serializer"
"github.com/DataDog/datadog-agent/pkg/trace/telemetry"
"github.com/DataDog/datadog-agent/pkg/util/compression"
"github.com/DataDog/datadog-agent/pkg/util/fxutil"
"github.com/DataDog/datadog-agent/pkg/util/option"

Expand Down Expand Up @@ -160,8 +162,13 @@ func runOTelAgentCommand(ctx context.Context, params *subcommands.GlobalParams,
return log.ForDaemon(params.LoggerName, "log_file", pkgconfigsetup.DefaultOTelAgentLogFile)
}),
logsagentpipelineimpl.Module(),
// We directly select fxzlib
compressionfxzlib.Module(),
logscompressionfx.Module(),
metricscompressionfx.Module(),
// For FX to provide the compression.Compressor interface (used by serializer.NewSerializer)
// implemented by the metricsCompression.Component
fx.Provide(func(c metricscompression.Component) compression.Compressor {
return c
}),
fx.Provide(serializer.NewSerializer),
// For FX to provide the serializer.MetricSerializer from the serializer.Serializer
fx.Provide(func(s *serializer.Serializer) serializer.MetricSerializer {
Expand Down
7 changes: 5 additions & 2 deletions cmd/security-agent/main_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ import (
"github.com/DataDog/datadog-agent/comp/dogstatsd"
"github.com/DataDog/datadog-agent/comp/dogstatsd/statsd"
"github.com/DataDog/datadog-agent/comp/metadata/host/hostimpl"
logscompression "github.com/DataDog/datadog-agent/comp/serializer/logscompression/def"
logscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
commonsettings "github.com/DataDog/datadog-agent/pkg/config/settings"

"github.com/DataDog/datadog-agent/pkg/collector/python"
Expand Down Expand Up @@ -124,7 +126,7 @@ func (s *service) Run(svcctx context.Context) error {
workloadmetafx.Module(workloadmeta.Params{
AgentType: workloadmeta.Remote,
}),
fx.Provide(func(log log.Component, config config.Component, statsd statsd.Component, wmeta workloadmeta.Component) (status.InformationProvider, *agent.RuntimeSecurityAgent, error) {
fx.Provide(func(log log.Component, config config.Component, statsd statsd.Component, wmeta workloadmeta.Component, compression logscompression.Component) (status.InformationProvider, *agent.RuntimeSecurityAgent, error) {
stopper := startstop.NewSerialStopper()

statsdClient, err := statsd.CreateForHostPort(setup.GetBindHost(config), config.GetInt("dogstatsd_port"))
Expand All @@ -138,7 +140,7 @@ func (s *service) Run(svcctx context.Context) error {
return status.NewInformationProvider(nil), nil, err
}

runtimeAgent, err := runtime.StartRuntimeSecurity(log, config, hostnameDetected, stopper, statsdClient, wmeta)
runtimeAgent, err := runtime.StartRuntimeSecurity(log, config, hostnameDetected, stopper, statsdClient, wmeta, compression)
if err != nil {
return status.NewInformationProvider(nil), nil, err
}
Expand Down Expand Up @@ -175,6 +177,7 @@ func (s *service) Run(svcctx context.Context) error {
}
}),
settingsimpl.Module(),
logscompressionfx.Module(),
)

return err
Expand Down
Loading

0 comments on commit 96d253e

Please sign in to comment.